Skip to content

Commit 17892a8

Browse files
authored
fix: Return EN locale w/out Promise.resolve(), prerender language picker in header (#1370)
1 parent 0b1a698 commit 17892a8

2 files changed

Lines changed: 10 additions & 11 deletions

File tree

src/components/header/index.jsx

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -133,16 +133,15 @@ function LanguagePicker() {
133133
}
134134
aria-label={translate('i18n', 'selectYourLanguage')}
135135
>
136-
{typeof window !== 'undefined' &&
137-
Object.entries(config.locales).map(([id, label]) => (
138-
<button
139-
class={cx(id == lang && style.current)}
140-
data-value={id}
141-
onClick={e => setLang(e.currentTarget.dataset.value)}
142-
>
143-
{label}
144-
</button>
145-
))}
136+
{Object.entries(config.locales).map(([id, label]) => (
137+
<button
138+
class={cx(id == lang && style.current)}
139+
data-value={id}
140+
onClick={e => setLang(e.currentTarget.dataset.value)}
141+
>
142+
{label}
143+
</button>
144+
))}
146145
</ExpandableNavLink>
147146
)}
148147
</NavMenu>

src/lib/i18n.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export function LanguageProvider({ children }) {
5252
const [lang, setLang] = useState('en');
5353

5454
const translations = useResource(() => {
55-
if (lang == 'en') return Promise.resolve(englishTranslations);
55+
if (lang == 'en') return englishTranslations;
5656
let url = '';
5757
for (const translationURL in translationURLs) {
5858
if (translationURL.includes(`/${lang}.json`)) {

0 commit comments

Comments
 (0)