standardize type checks (#3830)

Author: JoviDeCroock

compat/src/render.js

@@ -109,14 +109,14 @@ options.vnode = vnode => {
 	let normalizedProps = props;
 
 	// only normalize props on Element nodes
-	if (typeof type === 'string') {
+	if (typeof type == 'string') {
 		const nonCustomElement = type.indexOf('-') === -1;
 		normalizedProps = {};
 
 		let style = props.style;
-		if (typeof style === 'object') {
+		if (typeof style == 'object') {
 			for (i in style) {
-				if (typeof style[i] === 'number' && !IS_NON_DIMENSIONAL.test(i)) {
+				if (typeof style[i] == 'number' && !IS_NON_DIMENSIONAL.test(i)) {
 					style[i] += 'px';
 				}
 			}
@@ -211,7 +211,7 @@ options.vnode = vnode => {
 			if (props.className != null) normalizedProps.class = props.className;
 			Object.defineProperty(normalizedProps, 'className', classNameDescriptor);
 		}
-	} else if (typeof type === 'function' && type.defaultProps) {
+	} else if (typeof type == 'function' && type.defaultProps) {
 		for (i in type.defaultProps) {
 			if (normalizedProps[i] === undefined) {
 				normalizedProps[i] = type.defaultProps[i];

compat/src/scheduler.js

@@ -19,6 +19,6 @@ export function unstable_runWithPriority(priority, callback) {
 }
 
 export const unstable_now =
-	typeof performance === 'object' && typeof performance.now === 'function'
+	typeof performance == 'object' && typeof performance.now == 'function'
 		? performance.now.bind(performance)
 		: () => Date.now();

src/create-element.js

@@ -56,17 +56,19 @@ export function createElement(type, props, children) {
  */
 export function normalizeToVNode(childVNode) {
 	let type = typeof childVNode;
-	if (childVNode == null || type === 'boolean') {
+	if (childVNode == null || type == 'boolean') {
 		return null;
 	}
-	if (type === 'object') {
+
+	if (type == 'object' || type == 'function') {
 		if (Array.isArray(childVNode)) {
 			return createElement(Fragment, null, childVNode);
 		}
-	} else if (type !== 'string' && type !== 'function') {
-		return String(childVNode);
+
+		return childVNode;
 	}
-	return childVNode;
+
+	return String(childVNode);
 }
 
 export function createRef() {

src/diff/children.js

@@ -184,7 +184,7 @@ function findMatchingIndex(
 	skewedIndex,
 	remainingOldChildren
 ) {
-	const type = typeof childVNode === 'string' ? null : childVNode.type;
+	const type = typeof childVNode == 'string' ? null : childVNode.type;
 	const key = type !== null ? childVNode.key : UNDEFINED;
 	let match = -1;
 	let x = skewedIndex - 1; // i - 1;

src/diff/mount.js

@@ -181,7 +181,7 @@ function mountElement(internal, dom) {
 				newValue = value;
 			} else if (
 				value != null &&
-				(isFullRender || typeof value === 'function')
+				(isFullRender || typeof value == 'function')
 			) {
 				setProperty(dom, i, value, null, isSvg);
 			}
@@ -392,7 +392,8 @@ function mountComponent(internal, startDom) {
 	if (renderResult == null) {
 		return startDom;
 	}
-	if (typeof renderResult === 'object') {
+
+	if (typeof renderResult == 'object') {
 		// dissolve unkeyed root fragments:
 		if (renderResult.type === Fragment && renderResult.key == null) {
 			renderResult = renderResult.props.children;

src/diff/patch.js

@@ -305,7 +305,7 @@ function patchComponent(internal, newVNode) {
 
 	if (renderResult == null) {
 		renderResult = [];
-	} else if (typeof renderResult === 'object') {
+	} else if (typeof renderResult == 'object') {
 		if (renderResult.type === Fragment && renderResult.key == null) {
 			renderResult = renderResult.props.children;
 		}

src/diff/props.js

@@ -92,7 +92,7 @@ export function setProperty(dom, name, value, oldValue, isSvg) {
 		// amount of exceptions would cost us too many bytes. On top of
 		// that other VDOM frameworks also always stringify `false`.
 
-		if (typeof value === 'function') {
+		if (typeof value == 'function') {
 			// never serialize functions as attribute values
 		} else if (value != null && (value !== false || name.indexOf('-') != -1)) {
 			dom.setAttribute(name, value);

src/tree.js

@@ -31,7 +31,7 @@ export function createInternal(vnode, parentInternal) {
 	// Text VNodes/Internals have an ID of 0 that is never used:
 	let vnodeId = 0;
 
-	if (typeof vnode === 'string') {
+	if (typeof vnode == 'string') {
 		// type = null;
 		flags |= TYPE_TEXT;
 		props = vnode;
@@ -61,7 +61,7 @@ export function createInternal(vnode, parentInternal) {
 
 		// flags = typeof type === 'function' ? COMPONENT_NODE : ELEMENT_NODE;
 		flags |=
-			typeof type === 'function'
+			typeof type == 'function'
 				? type.prototype && type.prototype.render
 					? TYPE_CLASS
 					: props._parentDom