Files that are not pure Preact component exporters shouldn't create an HMR boundary

[tommie]

I'm using Vite, but I think this applies to all backends.

A file that has "other stuff" than Preact components must let HMR reload the page, e.g. by not calling accept at all, or calling invalidate.

The Vite React Refresh plugin checks that all exports are components, and ignores the HMR request if there are non-components: vitejs/vite-plugin-react-refresh@feec176

[rschristian]

The Vite React Refresh plugin checks that all exports are components

I think we'd need to go a step further than this due to signals, as state can be hoisted outside of the component (but in the same module). For example:

const text = signal('');

export function MyComponent() {
    return <input onInput={(e) => (text.value = e.currentTarget.value)} />;
}

Any HMR update should keep the text content of the input but the signal will get reset back to '', which can be confusing.

That being said, for non-signal use, I do feel the React plugin is a bit restricting and triggers reloads when it's really not necessary. Might just be my opinion, but I wonder if there's a happy middle ground w/ some signal detection.