refactor: Remove devtoolsInProd option, default to dev/prod (#112)

Author: rschristian

README.md

@@ -47,8 +47,7 @@ export default defineConfig({
 
 | Option | Type | Default | Description |
 |---|---|---|---|
-| `devtoolsInProd` | `boolean` | `false` | Inject devtools bridge in production bundle instead of only in development mode |
-| `devToolsEnabled` | `boolean` | `true` | Inject devtools bridge |
+| `devToolsEnabled` | `boolean` | `!isProduction` | Inject devtools bridge |
 | `prefreshEnabled` | `boolean` | `true` | Inject [Prefresh](https://github.com/preactjs/prefresh) for HMR |
 | `reactAliasesEnabled` | `boolean` | `true` | Aliases `react`, `react-dom` to `preact/compat` |
 | `babel` | `object` | | See [Babel configuration](#babel-configuration) |

src/devtools.ts

@@ -7,13 +7,11 @@ import type { RollupFilter } from "./utils.js";
 import { parseId } from "./utils.js";
 
 export interface PreactDevtoolsPluginOptions {
-	devtoolsInProd?: boolean;
 	devToolsEnabled?: boolean;
 	shouldTransform: RollupFilter;
 }
 
 export function preactDevtoolsPlugin({
-	devtoolsInProd,
 	devToolsEnabled,
 	shouldTransform,
 }: PreactDevtoolsPluginOptions): Plugin {
@@ -39,8 +37,7 @@ export function preactDevtoolsPlugin({
 
 		configResolved(resolvedConfig) {
 			config = resolvedConfig;
-			devToolsEnabled =
-				devToolsEnabled ?? (!config.isProduction || devtoolsInProd);
+			devToolsEnabled = devToolsEnabled ?? !config.isProduction;
 		},
 
 		resolveId(url, importer = "") {

src/index.ts

@@ -26,15 +26,9 @@ export type BabelOptions = Omit<
 >;
 
 export interface PreactPluginOptions {
-	/**
-	 * Inject devtools bridge in production bundle instead of only in development mode.
-	 * @default false
-	 */
-	devtoolsInProd?: boolean;
-
 	/**
 	 * Whether to use Preact devtools
-	 * @default true
+	 * @default !isProduction
 	 */
 	devToolsEnabled?: boolean;
 
@@ -111,7 +105,6 @@ export interface PreactBabelOptions extends BabelOptions {
 
 // Taken from https://github.com/vitejs/vite/blob/main/packages/plugin-react/src/index.ts
 function preactPlugin({
-	devtoolsInProd,
 	devToolsEnabled,
 	prefreshEnabled,
 	reactAliasesEnabled,
@@ -146,7 +139,6 @@ function preactPlugin({
 		exclude || [/node_modules/],
 	);
 
-	devtoolsInProd = devtoolsInProd ?? false;
 	prefreshEnabled = prefreshEnabled ?? true;
 	reactAliasesEnabled = reactAliasesEnabled ?? true;
 	prerender = prerender ?? { enabled: false };
@@ -203,8 +195,7 @@ function preactPlugin({
 		},
 		configResolved(resolvedConfig) {
 			config = resolvedConfig;
-			devToolsEnabled =
-				devToolsEnabled ?? (!config.isProduction || devtoolsInProd);
+			devToolsEnabled = devToolsEnabled ?? !config.isProduction;
 			useBabel ||= !config.isProduction || !!devToolsEnabled;
 		},
 		async transform(code, url) {
@@ -283,9 +274,8 @@ function preactPlugin({
 			: []),
 		jsxPlugin,
 		preactDevtoolsPlugin({
-			devtoolsInProd,
 			devToolsEnabled,
-			shouldTransform,
+			shouldTransform
 		}),
 		...(prefreshEnabled
 			? [prefresh({ include, exclude, parserPlugins: baseParserOptions })]