Avoid closing over vnodes in component updater (#973)

* Avoid closing over vnodes in component updater

* Fix component updater callback type

---------

Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>

Author: developit

.changeset/crisp-sides-talk.md

@@ -0,0 +1,5 @@
+---
+"@preact/signals": patch
+---
+
+Avoid closing over VNodes in component updater callbacks.

packages/preact/src/index.ts

@@ -235,11 +235,7 @@ hook(OptionsTypes.RENDER, (old, vnode) => {
 			updater = component._updater;
 			if (updater === undefined) {
 				component._updater = updater = createUpdater(
-					() => {
-						if (DEVTOOLS_ENABLED) updater!._debugCallback?.call(updater);
-						component._updateFlags |= HAS_PENDING_UPDATE;
-						component.setState({});
-					},
+					createComponentUpdateCallback(component),
 					typeof vnode.type === "function"
 						? vnode.type.displayName || vnode.type.name
 						: ""
@@ -252,6 +248,14 @@ hook(OptionsTypes.RENDER, (old, vnode) => {
 	}
 });
 
+function createComponentUpdateCallback(component: AugmentedComponent) {
+	return function (this: Effect) {
+		if (DEVTOOLS_ENABLED) this._debugCallback?.call(this);
+		component._updateFlags |= HAS_PENDING_UPDATE;
+		component.setState({});
+	};
+}
+
 /** Finish current updater if a component errors */
 hook(OptionsTypes.CATCH_ERROR, (old, error, vnode, oldVNode) => {
 	setCurrentUpdater();