Skip to content

Commit 34d4433

Browse files
committed
Add more coverage for bidder removal fields
1 parent c32bcc2 commit 34d4433

14 files changed

+148
-218
lines changed

src/test/groovy/org/prebid/server/functional/model/request/auction/AdjustmentRule.groovy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@ package org.prebid.server.functional.model.request.auction
33
import com.fasterxml.jackson.annotation.JsonProperty
44
import com.fasterxml.jackson.databind.PropertyNamingStrategies
55
import com.fasterxml.jackson.databind.annotation.JsonNaming
6+
import groovy.transform.EqualsAndHashCode
67
import groovy.transform.ToString
78
import org.prebid.server.functional.model.Currency
89

910
@JsonNaming(PropertyNamingStrategies.LowerCaseStrategy)
1011
@ToString(includeNames = true, ignoreNulls = true)
12+
@EqualsAndHashCode
1113
class AdjustmentRule {
1214

1315
@JsonProperty('adjtype')

src/test/groovy/org/prebid/server/functional/model/request/auction/AppExt.groovy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
package org.prebid.server.functional.model.request.auction
22

3+
import groovy.transform.EqualsAndHashCode
34
import groovy.transform.ToString
45

56
@ToString(includeNames = true, ignoreNulls = true)
7+
@EqualsAndHashCode
68
class AppExt {
79

810
AppExtData data

src/test/groovy/org/prebid/server/functional/model/request/auction/AppExtData.groovy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
package org.prebid.server.functional.model.request.auction
22

3+
import groovy.transform.EqualsAndHashCode
34
import groovy.transform.ToString
45

56
@ToString(includeNames = true, ignoreNulls = true)
7+
@EqualsAndHashCode
68
class AppExtData {
79

810
String language

src/test/groovy/org/prebid/server/functional/model/request/auction/BidAdjustment.groovy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@ package org.prebid.server.functional.model.request.auction
22

33
import com.fasterxml.jackson.databind.PropertyNamingStrategies
44
import com.fasterxml.jackson.databind.annotation.JsonNaming
5+
import groovy.transform.EqualsAndHashCode
56
import groovy.transform.ToString
67
import org.prebid.server.functional.util.PBSUtils
78

89
@JsonNaming(PropertyNamingStrategies.LowerCaseStrategy)
910
@ToString(includeNames = true, ignoreNulls = true)
11+
@EqualsAndHashCode
1012
class BidAdjustment {
1113

1214
Map<BidAdjustmentMediaType, BidAdjustmentRule> mediaType

src/test/groovy/org/prebid/server/functional/model/request/auction/BidAdjustmentFactors.groovy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,13 @@ import com.fasterxml.jackson.annotation.JsonAnyGetter
44
import com.fasterxml.jackson.annotation.JsonAnySetter
55
import com.fasterxml.jackson.databind.PropertyNamingStrategies
66
import com.fasterxml.jackson.databind.annotation.JsonNaming
7+
import groovy.transform.EqualsAndHashCode
78
import groovy.transform.ToString
89
import org.prebid.server.functional.model.bidder.BidderName
910

1011
@JsonNaming(PropertyNamingStrategies.LowerCaseStrategy)
1112
@ToString(includeNames = true, ignoreNulls = true)
13+
@EqualsAndHashCode
1214
class BidAdjustmentFactors {
1315

1416
@JsonAnySetter

src/test/groovy/org/prebid/server/functional/model/request/auction/BidAdjustmentRule.groovy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
package org.prebid.server.functional.model.request.auction
22

33
import com.fasterxml.jackson.annotation.JsonProperty
4+
import groovy.transform.EqualsAndHashCode
45
import groovy.transform.ToString
56

67
@ToString(includeNames = true, ignoreNulls = true)
8+
@EqualsAndHashCode
79
class BidAdjustmentRule {
810

911
@JsonProperty('*')

src/test/groovy/org/prebid/server/functional/model/request/auction/Prebid.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import com.fasterxml.jackson.annotation.JsonProperty
44
import com.fasterxml.jackson.databind.PropertyNamingStrategies
55
import com.fasterxml.jackson.databind.annotation.JsonNaming
66
import groovy.transform.ToString
7-
import org.prebid.server.functional.model.ChannelType
87
import org.prebid.server.functional.model.bidder.BidderName
98
import org.prebid.server.functional.model.config.AlternateBidderCodes
109
import org.prebid.server.functional.model.request.Channel
@@ -54,4 +53,5 @@ class Prebid {
5453
Map<String, String> keyValuePairs
5554
Boolean supportDeals
5655
String integration
56+
Map<String, String> bidders
5757
}

src/test/groovy/org/prebid/server/functional/tests/BidAdjustmentSpec.groovy

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.prebid.server.functional.tests
22

3-
43
import org.prebid.server.functional.model.bidder.Generic
54
import org.prebid.server.functional.model.config.AccountAuctionConfig
65
import org.prebid.server.functional.model.config.AccountConfig
@@ -53,6 +52,7 @@ import static org.prebid.server.functional.model.request.auction.VideoPlcmtSubty
5352
import static org.prebid.server.functional.model.response.auction.ErrorType.PREBID
5453
import static org.prebid.server.functional.testcontainers.Dependencies.getNetworkServiceContainer
5554
import static org.prebid.server.functional.util.PBSUtils.getRandomDecimal
55+
import static org.prebid.server.functional.util.PBSUtils.roundDecimal
5656

5757
class BidAdjustmentSpec extends BaseSpec {
5858

@@ -106,7 +106,7 @@ class BidAdjustmentSpec extends BaseSpec {
106106

107107
def "PBS should prefer bid price adjustment based on media type when request has per-media-type bid adjustment factors"() {
108108
given: "Default bid request with bid adjustment"
109-
def bidAdjustment = randomDecimal
109+
def bidAdjustment = roundDecimal(getRandomDecimal(), 0)
110110
def mediaTypeBidAdjustment = bidAdjustmentFactor
111111
def bidRequest = BidRequest.getDefaultBidRequest(SITE).tap {
112112
ext.prebid.bidAdjustmentFactors = new BidAdjustmentFactors().tap {
@@ -126,6 +126,10 @@ class BidAdjustmentSpec extends BaseSpec {
126126
assert response?.seatbid?.first?.bid?.first?.price == bidResponse.seatbid.first.bid.first.price *
127127
mediaTypeBidAdjustment
128128

129+
and: "Bidder request should contain bid bid adjustment factors"
130+
def bidderRequest = bidder.getBidderRequest(bidRequest.id)
131+
assert bidderRequest.ext.prebid.bidAdjustmentFactors == bidRequest.ext.prebid.bidAdjustmentFactors
132+
129133
where:
130134
bidAdjustmentFactor << [0.9, 1.1]
131135
}
@@ -239,6 +243,9 @@ class BidAdjustmentSpec extends BaseSpec {
239243
assert bidderRequest.imp.bidFloorCur == [currency]
240244
assert bidderRequest.imp.bidFloor == [impPrice]
241245

246+
and: "Bidder request should contain bid adjustments"
247+
assert bidderRequest.ext.prebid.bidAdjustments == bidRequest.ext.prebid.bidAdjustments
248+
242249
where:
243250
adjustmentType | ruleValue | mediaType | bidRequest
244251
MULTIPLIER | getRandomDecimal(MIN_ADJUST_VALUE, MAX_MULTIPLIER_ADJUST_VALUE) | BANNER | BidRequest.defaultBidRequest

0 commit comments

Comments
 (0)