Skip to content

Commit 695d694

Browse files
committed
clean up redundant code which obtains endpoint url
1 parent 64b827f commit 695d694

File tree

2 files changed

+6
-17
lines changed

2 files changed

+6
-17
lines changed

src/main/java/org/prebid/server/bidder/mobilefuse/MobilefuseBidder.java

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,6 @@ public MobilefuseBidder(String endpointUrl, JacksonMapper mapper) {
4545

4646
@Override
4747
public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request) {
48-
final String endpoint = request.getImp().stream()
49-
.map(this::parseImpExt)
50-
.filter(Objects::nonNull)
51-
.findFirst()
52-
.map(this::makeUrl)
53-
.orElse(null);
54-
55-
if (endpoint == null) {
56-
return Result.withError(BidderError.badInput("Invalid ExtImpMobilefuse value"));
57-
}
58-
5948
final List<Imp> modifiedImps = request.getImp().stream()
6049
.map(this::modifyImp)
6150
.filter(Objects::nonNull)
@@ -66,7 +55,7 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
6655
}
6756

6857
final BidRequest modifiedRequest = request.toBuilder().imp(modifiedImps).build();
69-
return Result.withValue(BidderUtil.defaultRequest(modifiedRequest, endpoint, mapper));
58+
return Result.withValue(BidderUtil.defaultRequest(modifiedRequest, endpointUrl, mapper));
7059
}
7160

7261
private Imp modifyImp(Imp imp) {
@@ -75,6 +64,10 @@ private Imp modifyImp(Imp imp) {
7564
}
7665

7766
final ExtImpMobilefuse impExt = parseImpExt(imp);
67+
if (impExt == null) {
68+
return null;
69+
}
70+
7871
final ObjectNode skadn = parseSkadn(imp.getExt());
7972
return imp.toBuilder()
8073
.tagid(Objects.toString(impExt.getPlacementId(), "0"))
@@ -98,10 +91,6 @@ private ObjectNode parseSkadn(ObjectNode impExt) {
9891
}
9992
}
10093

101-
private String makeUrl(ExtImpMobilefuse extImp) {
102-
return endpointUrl;
103-
}
104-
10594
@Override
10695
public final Result<List<BidderBid>> makeBids(BidderCall<BidRequest> httpCall, BidRequest bidRequest) {
10796
try {

src/test/java/org/prebid/server/bidder/mobilefuse/MobilefuseBidderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public void makeHttpRequestsShouldReturnErrorIfNoValidExtFound() {
9292

9393
// then
9494
assertThat(result.getErrors())
95-
.containsExactly(BidderError.badInput("Invalid ExtImpMobilefuse value"));
95+
.containsExactly(BidderError.badInput("No valid imps"));
9696
assertThat(result.getValue()).isEmpty();
9797
}
9898

0 commit comments

Comments
 (0)