SmileWanted endpoint now supports dynamic zoneId and integrates prebid server technology

Author: QuentinGallard

src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java

@@ -1,21 +1,25 @@
 package org.prebid.server.bidder.smilewanted;
 
+import com.fasterxml.jackson.core.type.TypeReference;
 import com.iab.openrtb.request.BidRequest;
 import com.iab.openrtb.request.Imp;
 import com.iab.openrtb.response.BidResponse;
 import com.iab.openrtb.response.SeatBid;
 import io.vertx.core.MultiMap;
-import io.vertx.core.http.HttpMethod;
 import org.apache.commons.collections4.CollectionUtils;
 import org.prebid.server.bidder.Bidder;
 import org.prebid.server.bidder.model.BidderBid;
 import org.prebid.server.bidder.model.BidderCall;
 import org.prebid.server.bidder.model.BidderError;
 import org.prebid.server.bidder.model.HttpRequest;
 import org.prebid.server.bidder.model.Result;
+import org.prebid.server.exception.PreBidException;
 import org.prebid.server.json.DecodeException;
 import org.prebid.server.json.JacksonMapper;
+import org.prebid.server.proto.openrtb.ext.ExtPrebid;
+import org.prebid.server.proto.openrtb.ext.request.smilewanted.ExtImpSmilewanted;
 import org.prebid.server.proto.openrtb.ext.response.BidType;
+import org.prebid.server.util.BidderUtil;
 import org.prebid.server.util.HttpUtil;
 
 import java.util.Collections;
@@ -27,6 +31,11 @@ public class SmileWantedBidder implements Bidder<BidRequest> {
     private static final String SW_INTEGRATION_TYPE = "prebid_server";
     private static final String X_OPENRTB_VERSION = "2.5";
     private static final int DEFAULT_AT = 1;
+    private static final String ZONE_ID_MACRO = "{{ZoneId}}";
+
+    private static final TypeReference<ExtPrebid<?, ExtImpSmilewanted>> SMILEWANTED_EXT_TYPE_REFERENCE =
+            new TypeReference<>() {
+            };
 
     private final String endpointUrl;
     private final JacksonMapper mapper;
@@ -38,15 +47,30 @@ public SmileWantedBidder(String endpointUrl, JacksonMapper mapper) {
 
     @Override
     public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request) {
+        final ExtImpSmilewanted extImpSmilewanted;
+
+        try {
+            extImpSmilewanted = parseImpExt(request.getImp().getFirst());
+        } catch (PreBidException e) {
+            return Result.withError(BidderError.badInput(e.getMessage()));
+        }
+
         final BidRequest outgoingRequest = request.toBuilder().at(DEFAULT_AT).build();
+        final String url = endpointUrl.replace(ZONE_ID_MACRO, extImpSmilewanted.getZoneId());
 
-        return Result.withValue(HttpRequest.<BidRequest>builder()
-                .method(HttpMethod.POST)
-                .uri(endpointUrl)
-                .headers(createHeaders())
-                .payload(outgoingRequest)
-                .body(mapper.encodeToBytes(outgoingRequest))
-                .build());
+        return Result.withValue(BidderUtil.defaultRequest(
+                outgoingRequest,
+                createHeaders(),
+                url,
+                mapper));
+    }
+
+    private ExtImpSmilewanted parseImpExt(Imp imp) {
+        try {
+            return mapper.mapper().convertValue(imp.getExt(), SMILEWANTED_EXT_TYPE_REFERENCE).getBidder();
+        } catch (IllegalArgumentException e) {
+            throw new PreBidException("Missing bidder ext in impression with id: " + imp.getId());
+        }
     }
 
     private static MultiMap createHeaders() {

src/main/java/org/prebid/server/proto/openrtb/ext/request/smilewanted/ExtImpSmilewanted.java

@@ -0,0 +1,11 @@
+package org.prebid.server.proto.openrtb.ext.request.smilewanted;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import lombok.Value;
+
+@Value(staticConstructor = "of")
+public class ExtImpSmilewanted {
+
+    @JsonProperty("zoneId")
+    String zoneId;
+}

…ig/bidder/SimpleWantedConfiguration.java …fig/bidder/SmileWantedConfiguration.javasrc/main/java/org/prebid/server/spring/config/bidder/SimpleWantedConfiguration.java renamed to src/main/java/org/prebid/server/spring/config/bidder/SmileWantedConfiguration.java src/main/java/org/prebid/server/spring/config/bidder/SimpleWantedConfiguration.java renamed to src/main/java/org/prebid/server/spring/config/bidder/SmileWantedConfiguration.java

@@ -17,7 +17,7 @@
 
 @Configuration
 @PropertySource(value = "classpath:/bidder-config/smilewanted.yaml", factory = YamlPropertySourceFactory.class)
-public class SimpleWantedConfiguration {
+public class SmileWantedConfiguration {
 
     private static final String BIDDER_NAME = "smilewanted";
 

src/main/resources/bidder-config/smilewanted.yaml

@@ -1,6 +1,6 @@
 adapters:
   smilewanted:
-    endpoint: https://prebid-server.smilewanted.com
+    endpoint: https://prebid-server.smilewanted.com/java/{{ZoneId}}
     meta-info:
       maintainer-email: [email protected]
       app-media-types: