Skip to content

Commit b92f76b

Browse files
author
Paul Duncan
committed
Correction to use of Optionals
1 parent 870c3f3 commit b92f76b

File tree

1 file changed

+16
-17
lines changed

1 file changed

+16
-17
lines changed

predicthq/endpoints/v1/saved_locations/schemas.py

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -136,13 +136,12 @@ class SummaryInsights(PhqModel):
136136
attended_event_count: int
137137
non_attended_event_count: int
138138
unscheduled_event_count: int
139-
# TODO: remove Optional when implemented
140-
demand_surge_count: int | None = None
141-
venue_count: int | None = None
142-
pes_total_sum: int | None = None
143-
pes_accommodation_sum: int | None = None
144-
pes_hospitality_sum: int | None = None
145-
pes_transportation_sum: int | None = None
139+
demand_surge_count: Optional[int] = None
140+
venue_count: Optional[int] = None
141+
pes_total_sum: Optional[int] = None
142+
pes_accommodation_sum: Optional[int] = None
143+
pes_hospitality_sum: Optional[int] = None
144+
pes_transportation_sum: Optional[int] = None
146145

147146

148147
Position = tuple[float, float] | tuple[float, float, float]
@@ -185,9 +184,9 @@ class Place(PhqModel):
185184
place_id: int
186185
type: str
187186
name: str
188-
county: str | None = None
189-
region: str | None = None
190-
country: str | None = None
187+
county: Optional[str] = None
188+
region: Optional[str] = None
189+
country: Optional[str] = None
191190
geojson: PlaceGeoJson
192191

193192

@@ -205,13 +204,13 @@ class GeoJson(PhqModel):
205204

206205

207206
class SavedLocationBase(PhqModel):
208-
location_code: str | None = None
209-
name: str | None = None
210-
description: str | None = None
211-
labels: list[str] | None = None
207+
location_code: Optional[str] = None
208+
name: Optional[str] = None
209+
description: Optional[str] = None
210+
labels: Optional[list[str]] = None
212211
geojson: GeoJson | None = None
213-
place_ids: list[int] | None = None
214-
formatted_address: str | None = None
212+
place_ids: Optional[list[int]] = None
213+
formatted_address: Optional[str] = None
215214

216215

217216
class SavedLocation(SavedLocationBase):
@@ -226,7 +225,7 @@ class SavedLocation(SavedLocationBase):
226225
user_id: Optional[str] = None
227226
subscription_valid_types: Annotated[
228227
list[SubscriptionValidType], Field(default_factory=list)
229-
] # indicates if location is within org subscription
228+
]
230229
status: SavedLocationStatus
231230
summary_insights: Annotated[list[SummaryInsights], Field(default_factory=list)]
232231
places: Annotated[list[Place], Field(default_factory=list)]

0 commit comments

Comments
 (0)