Skip to content

Commit 335a0d6

Browse files
committed
enh - use plt.show() and remove plt.close
Plots are now shown when running not only a notebook but also a script (py file)
1 parent c177dd5 commit 335a0d6

1 file changed

Lines changed: 7 additions & 15 deletions

File tree

pcntoolkit/util/plotter.py

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -220,12 +220,9 @@ def _plot_centiles(
220220
plt.ylabel(response_var)
221221
if save_dir:
222222
plt.savefig(os.path.join(save_dir, f"{plotname}.png"), dpi=300)
223-
else:
224-
plt.show(block=False)
223+
224+
plt.show()
225225
plt.tight_layout()
226-
plt.close()
227-
228-
229226

230227
def plot_centiles_advanced(
231228
model: "NormativeModel",
@@ -622,9 +619,8 @@ def _plot_centiles_advanced(
622619
plt.ylabel(response_var)
623620
if save_dir:
624621
plt.savefig(os.path.join(save_dir, f"{plotname}.png"), dpi=300)
625-
else:
626-
plt.show(block=False)
627-
plt.close()
622+
623+
plt.show()
628624

629625
def plot_qq(
630626
data: NormData,
@@ -797,9 +793,8 @@ def _plot_qq(
797793
plt.axis((-bound, bound, -bound, bound))
798794
if save_dir:
799795
plt.savefig(os.path.join(save_dir, f"qq_{response_var}_{data.name}.png"), dpi=300)
800-
else:
801-
plt.show(block=False)
802-
plt.close()
796+
797+
plt.show()
803798

804799

805800
def plot_ridge(data: NormData, variable: Literal["Z", "Y"], split_by: str, response_vars: List[str] | None = None, save_dir: str | None = None, **kwargs: Any) -> None:
@@ -877,8 +872,5 @@ def label(x, color, label):
877872
plt.tight_layout()
878873
if save_dir:
879874
plt.savefig(os.path.join(save_dir, f"ridge_{response_var}_{variable}_{split_by}_{data.name}.png"), dpi=300)
880-
else:
881-
plt.show(block=False)
882-
plt.close()
883-
884875

876+
plt.show()

0 commit comments

Comments
 (0)