feat(queries): warnings for invalid query config parameters

[rdougan]

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

I'm using the following code in my app:

export default compose(
  connect(mapStateToProps),
  firebaseConnect(props => ({
    path: 'channels',
    queryParams: ['orderByChild=receiver', `equalTo= EAbx9f4RtNRjVBR1ABuTUxMBmps2`],
  })),
)(Incoming);

The view is populated, however an unhandled promise error appears after a second. Database: Client doesn't have permission to access the desired data.

The following code works:

firebase.database().ref('/channels')
  .orderByChild('receiver')
  .equalTo('EAbx9f4RtNRjVBR1ABuTUxMBmps2')
  .once('value', (snapshot) => {
    const channels = _.map(snapshot.val(), (val, uid) => { uid });
    console.log(channels.length);
  });

The rules are simple:

{
  "rules": {
    "channels": {
      ".read": "auth != null",
      ".write": "auth != null",
    },
  },
}

What is the expected behavior?

No unhandled promise warning should appear.

Which versions of dependencies, and which browser and OS are affected by this issue? Did this work in previous versions or setups?

2.1.8

[prescottprue]

Maybe it was just an error in copying, but it looks like your equalTo query param has an extra space at the beginning:

`equalTo= EAbx9f4RtNRjVBR1ABuTUxMBmps2`
// should be
`equalTo=EAbx9f4RtNRjVBR1ABuTUxMBmps2`

That said, not sure that is the issue based on the rules you posted.

Turning on logErrors: true in your config should make the error message more clear, but if you are using userProfile: 'users', then that will attempt to write your profile to the 'users' path. The rules you posted do not seem to include anything for the users path, so it could be an issue in the profile listener.

If you change your rules to the following, things should work as you expect:

{
  "rules": {
    "channels": {
      ".read": "auth != null",
      ".write": "auth != null",
    },
    "users": {
       "$uid": {
         ".read": "auth != null && auth.uid === $uid",
         ".write": "auth != null && auth.uid === $uid"
       }
    }
  }
}

[rdougan]

The space was just an error with copying.

I've done some more digging and it looks like the object version being passed to firebaseConnect does not work, but the string version does.

Works:

export default compose(
  connect(mapStateToProps),
  firebaseConnect(props => {
    console.log('Confirming UID is correct', props.user.uid);
    return [`/channels#orderByChild=sender&equalTo=${props.user.uid}`];
  }),
)(Channels);

Not working:

export default compose(
  connect(mapStateToProps),
  firebaseConnect(props => {
    console.log('Confirming UID is correct', props.user.uid);
    
    return {
      path: '/channels',
      queryParams: ['orderByChild=sender', `equalTo=${props.user.uid}`],
    };
  }),
)(Channels);

Aaaaaaand while typing this, I figured it out! This works:

export default compose(
  connect(mapStateToProps),
  firebaseConnect(props => {
    console.log('Confirming UID is correct', props.user.uid);

    return [{
      path: '/channels',
      queryParams: ['orderByChild=sender', `equalTo=${props.user.uid}`],
    }];
  }),
)(Channels);

I have been returning an object, not an array. Looks like an object isn't fully parsed. This is the error:

RRF: Error retrieving data for path: /channels, storeAs: undefined. Firebase:', { [Error: Database: Client doesn't have permission to access the desired data. (database/permission-denied).

[prescottprue]

Glad you figured it out! There has been a past feature request to warn when queries are incorrectly formatted, so going to leave this open until we link them. Thanks for reaching out