Skip to content

Commit 34dd857

Browse files
authored
v0.2.5 (#43)
* feat(core): `tests` folder renamed to `test` (with associated updates to npm scripts) * feat(test): test/mocha.opts file created to contain mocha options (makes npm scripts more readable) * feat(docs): github contributing files added (`.github/CONTRIBUTING.md`, `.github/ISSUE_TEMPLATE.md`, `.github/PULL_REQUEST_TEMPLATE.md`) * fix(docs): fix typos within getting started section of `README.md`
1 parent 9313679 commit 34dd857

21 files changed

+97
-8
lines changed

.github/CONTRIBUTING.md

+56
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
# Contributing Guidelines
2+
3+
Thanks for taking the time to look into contributing! Below are some basic conventions for contributing to this project.
4+
5+
### General
6+
7+
Please make sure that there aren't existing pull requests attempting to address the issue mentioned. Likewise, please check for issues related to update, as someone else may be working on the issue in a branch or fork.
8+
9+
* Non-trivial changes should be discussed in an issue or on [gitter](https://gitter.im/redux-firebase/Lobby) or within an issue first
10+
* Develop in a topic branch, not master
11+
* Squash your commits
12+
13+
### Commit Message Format
14+
15+
Each commit message should include a **type**, a **scope** and a **subject**:
16+
17+
```
18+
<type>(<scope>): <subject>
19+
```
20+
21+
Lines should not exceed 100 characters. This allows the message to be easier to read on github as well as in various git tools and produces a nice, neat commit log ie:
22+
23+
```
24+
#218 docs(example): allow user to configure webpack stats output
25+
#271 feat(standard): add style config and refactor to match
26+
#270 fix(config): only override publicPath when served by webpack
27+
#269 feat(eslint-config-defaults): replace eslint-config-airbnb
28+
#268 feat(config): allow user to configure webpack stats output
29+
```
30+
31+
#### Type
32+
33+
Must be one of the following:
34+
35+
* **feat**: A new feature
36+
* **fix**: A bug fix
37+
* **docs**: Documentation only changes
38+
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing
39+
semi-colons, etc)
40+
* **refactor**: A code change that neither fixes a bug or adds a feature
41+
* **test**: Adding missing tests
42+
* **chore**: Changes to the build process or auxiliary tools and libraries such as documentation
43+
generation
44+
45+
#### Scope
46+
47+
The scope could be anything specifying place of the commit change. For example `webpack`,
48+
`babel`, `redux` etc...
49+
50+
#### Subject
51+
52+
The subject contains succinct description of the change:
53+
54+
* use the imperative, present tense: "change" not "changed" nor "changes"
55+
* don't capitalize first letter
56+
* no dot (.) at the end

.github/ISSUE_TEMPLATE.md

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
**Do you want to request a *feature* or report a *bug*?**
2+
3+
4+
**What is the current behavior?**
5+
6+
7+
**What is the expected behavior?**
8+
9+
10+
**Which versions of dependencies, and which browser are affected by this issue? Did this work in previous versions or setups?**
11+
12+
13+
**Steps to reproduce and if possible a minimal demo of the problem via [codesandbox](https://codesandbox.io/) or similar.**

.github/PULL_REQUEST_TEMPLATE.md

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
### Description
2+
3+
4+
### Check List
5+
If not relevant to pull request, check off as complete
6+
7+
- [ ] All tests passing
8+
- [ ] Docs updated with any changes or examples if applicable
9+
- [ ] Added tests to ensure new feature(s) work properly
10+
11+
### Relevant Issues
12+
<!-- * #1 -->

README.md

+7-3
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ import 'firebase/firestore'
4444
const firebaseConfig = {} // from Firebase Console
4545

4646
// Initialize firebase instance
47-
const firebaseApp = firebase.initializeApp(config)
47+
const firebaseApp = firebase.initializeApp(firebaseConfig)
4848
// Initialize Cloud Firestore through Firebase
4949
firebase.firestore();
5050

51-
// Add reduxReduxFirebase to compose
51+
// Add reduxFirestore store enhancer to store creator
5252
const createStoreWithFirebase = compose(
5353
reduxFirestore(firebaseApp), // firebase instance as first argument
5454
)(createStore)
@@ -66,7 +66,11 @@ const store = createStoreWithFirebase(rootReducer, initialState)
6666
Then pass store to your component's context using [react-redux's `Provider`](https://github.com/reactjs/react-redux/blob/master/docs/api.md#provider-store):
6767

6868
```js
69-
ReactDOM.render(
69+
import React from 'react';
70+
import { render } from 'react-dom';
71+
import { Provider } from 'react-redux';
72+
73+
render(
7074
<Provider store={store}>
7175
<MyRootComponent />
7276
</Provider>,

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "redux-firestore",
3-
"version": "0.2.4",
3+
"version": "0.2.5",
44
"description": "Redux bindings for Firestore.",
55
"main": "lib/index.js",
66
"module": "es/index.js",
@@ -22,9 +22,8 @@
2222
"build:umd:min": "cross-env BABEL_ENV=commonjs NODE_ENV=production webpack",
2323
"build": "npm run build:commonjs && npm run build:es && npm run build:umd && npm run build:umd:min",
2424
"watch": "npm run build:es -- --watch",
25-
"start": "webpack-dev-server --config example/webpack.config.js",
26-
"test": "mocha -R spec ./tests/setup.js ./tests/** --recursive --require babel-core/register",
27-
"test:cov": "istanbul cover ./node_modules/mocha/bin/_mocha -- ./tests/** --recursive --report lcov --require babel-core/register",
25+
"test": "mocha -R spec ./test/unit/**",
26+
"test:cov": "istanbul cover ./node_modules/mocha/bin/_mocha ./test/unit/**",
2827
"codecov": "cat coverage/lcov.info | codecov",
2928
"lint": "eslint .",
3029
"lint:fix": "npm run lint -- --fix",

tests/.eslintrc test/.eslintrc

File renamed without changes.

test/mocha.opts

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
--require babel-core/register
2+
--require ./test/setup
3+
--recursive
4+
--colors
5+
--report lcov

tests/setup.js test/setup.js

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)