v0.4.2

* fix(dataReducer): `DOCUMENT_ADDED` action type added to dataReducer - #84
* fix(query): `oneListenerPerPath` supports passing falsey values (before defining it at all would enable) - slight update to #77
* fix(query): prevent errors when combining string/object query config updated
* update(deps): [sinon](http://sinonjs.org/) and [sinon-chai](https://github.com/domenic/sinon-chai) dependencies updated (fixes child dep warning)

Author: prescottprue

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "redux-firestore",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "Redux bindings for Firestore.",
   "main": "lib/index.js",
   "module": "es/index.js",
@@ -68,8 +68,8 @@
     "prettier": "^1.10.2",
     "redux": "^3.7.2",
     "rimraf": "^2.6.2",
-    "sinon": "^3.3.0",
-    "sinon-chai": "^2.14.0",
+    "sinon": "^4.5.0",
+    "sinon-chai": "^3.0.0",
     "webpack": "^3.11.0"
   },
   "license": "MIT",

package.json

@@ -282,9 +282,9 @@ export function setListeners(firebase, dispatch, listeners) {
   }
 
   const { config } = firebase._;
-  const oneListenerPerPath = !!config.oneListenerPerPath;
 
-  if (oneListenerPerPath) {
+  // Only attach one listener (count of matching listener path calls is tracked)
+  if (config.oneListenerPerPath) {
     return listeners.forEach(listener => {
       const path = getQueryName(listener);
       const oldListenerCount = pathListenerCounts[path] || 0;
@@ -300,8 +300,7 @@ export function setListeners(firebase, dispatch, listeners) {
   }
 
   return listeners.forEach(listener => {
-    // Config for supporting attaching of multiple listeners
-
+    // Config for supporting attaching of multiple listener callbacks
     const multipleListenersEnabled = isFunction(config.allowMultipleListeners)
       ? config.allowMultipleListeners(listener, firebase._.listeners)
       : config.allowMultipleListeners;
@@ -343,9 +342,9 @@ export function unsetListeners(firebase, dispatch, listeners) {
     );
   }
   const { config } = firebase._;
-  const oneListenerPerPath = !!config.oneListenerPerPath;
 
-  if (oneListenerPerPath) {
+  // Keep one listener path even when detaching
+  if (config.oneListenerPerPath) {
     listeners.forEach(listener => {
       const path = getQueryName(listener);
       pathListenerCounts[path] -= 1;

src/actions/firestore.js

@@ -9,6 +9,7 @@ const {
   LISTENER_RESPONSE,
   LISTENER_ERROR,
   DELETE_SUCCESS,
+  DOCUMENT_ADDED,
   DOCUMENT_MODIFIED,
   DOCUMENT_REMOVED,
 } = actionTypes;
@@ -56,6 +57,7 @@ export default function dataReducer(state = {}, action) {
       // Set data to state (with merge) immutabily (lodash/fp's setWith creates copy)
       return setWith(Object, pathFromMeta(meta), mergedData, state);
     case DOCUMENT_MODIFIED:
+    case DOCUMENT_ADDED:
       return setWith(
         Object,
         pathFromMeta(action.meta),

src/reducers/dataReducer.js

@@ -18,11 +18,11 @@ const {
 
 /**
  * Case reducer for adding a document to a collection.
- * @param  {Array} collectionState - Redux state of current collection
+ * @param  {Array} [collectionState=[]] - Redux state of current collection
  * @param  {Object} action - The action that was dispatched
  * @return {Array} State with document modified
  */
-function addDoc(array, action) {
+function addDoc(array = [], action) {
   return [
     ...array.slice(0, action.payload.ordered.newIndex),
     { id: action.meta.doc, ...action.payload.data },

src/reducers/orderedReducer.js

@@ -157,6 +157,9 @@ function whereToStr(where) {
  * @return {String} String representing query settings
  */
 export function getQueryName(meta) {
+  if (isString(meta)) {
+    return meta;
+  }
   const { collection, doc, subcollections, where } = meta;
   if (!collection) {
     throw new Error('Collection is required to build query name');

src/utils/query.js

@@ -26,6 +26,20 @@ describe('dataReducer', () => {
   });
 
   describe('actionTypes', () => {
+    describe('DOCUMENT_ADDED', () => {
+      it('throws for no collection', () => {
+        const someDoc = {};
+        payload = { data: { abc: someDoc } };
+        meta = { collection, doc };
+        action = { meta, payload, type: actionTypes.DOCUMENT_ADDED };
+        result = dataReducer({}, action);
+        expect(result).to.have.nested.property(
+          `${collection}.${doc}.abc`,
+          someDoc,
+        );
+      });
+    });
+
     describe('LISTENER_RESPONSE', () => {
       it('returns state if payload is not defined', () => {
         action = { meta: 'test', type: actionTypes.LISTENER_RESPONSE };

test/unit/reducers/dataReducer.spec.js

@@ -16,6 +16,24 @@ describe('orderedReducer', () => {
   });
 
   describe('actionTypes', () => {
+    describe('DOCUMENT_ADDED', () => {
+      it('throws for no collection', () => {
+        const collection = 'test1';
+        const doc = 'test2';
+        const someDoc = { id: doc };
+        const payload = {
+          ordered: { newIndex: 0, oldIndex: -1 },
+          data: someDoc,
+        };
+        const meta = { collection, doc };
+        action = { meta, payload, type: actionTypes.DOCUMENT_ADDED };
+        const result = orderedReducer({}, action);
+        expect(result).to.have.nested.property(
+          `${collection}.0.id`,
+          someDoc.id,
+        );
+      });
+    });
     describe('LISTENER_RESPONSE', () => {
       it('returns state if payload is not defined', () => {
         action = { meta: 'test', type: actionTypes.LISTENER_RESPONSE };