v0.2.6

v0.2.6

Author: prescottprue

.codeclimate.yml

@@ -0,0 +1,10 @@
+languages:
+  JavaScript: true
+
+exclude_paths:
+- "lib/**"
+- "tests/**"
+- "examples/**"
+- "LICENSE.md"
+- "README.md"
+- "package.json"

README.md

@@ -25,10 +25,10 @@ If you're not, you can access the library on [unpkg](https://unpkg.com/redux-fir
 
 ## Complementary Package
 
-Most likely, you'll want react bindings, for that you will need [react-redux-firebase](https://github.com/prescottprue/react-redux-firebase). You can install the current v2.0.0 version it by running:
+Most likely, you'll want react bindings, for that you will need [react-redux-firebase](https://github.com/prescottprue/react-redux-firebase). You can install the current version it by running:
 
 ```sh
-npm install --save react-redux-firebase@next
+npm install --save react-redux-firebase
 ```
 
 [react-redux-firebase](https://github.com/prescottprue/react-redux-firebase) provides [`withFirestore`](http://docs.react-redux-firebase.com/history/v2.0.0/docs/api/withFirestore.html) and [`firestoreConnect`](http://docs.react-redux-firebase.com/history/v2.0.0/docs/api/withFirestore.html) higher order components, which handle automatically calling `redux-firestore` internally based on component's lifecycle (i.e. mounting/un-mounting)
@@ -84,7 +84,7 @@ render(
 
 ##### Functional Components
 
-It is common to make react components "stateless" meaning that the component is just a function. This can be useful, but then can limit usage of lifecycle hooks and other features of Component Classes. [`recompose` helps solve this](https://github.com/acdlite/recompose/blob/master/docs/API.md) by providing Higher Order Component functions such as `withContext`, `lifecycle`, and `withHandlers`.
+It is common to make react components "functional" meaning that the component is just a function instead of being a `class` which `extends React.Component`. This can be useful, but then can limit usage of lifecycle hooks and other features of Component Classes. [`recompose` helps solve this](https://github.com/acdlite/recompose/blob/master/docs/API.md) by providing Higher Order Component functions such as `withContext`, `lifecycle`, and `withHandlers`.
 
 ```js
 import { connect } from 'react-redux'

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "redux-firestore",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "description": "Redux bindings for Firestore.",
   "main": "lib/index.js",
   "module": "es/index.js",
@@ -85,4 +85,4 @@
       ]
     }
   ]
-}
+}

package.json

@@ -179,8 +179,6 @@ export const detachListener = (firebase, dispatch, meta) => {
   if (firebase._.listeners[name]) {
     firebase._.listeners[name]();
     delete firebase._.listeners[name]; // eslint-disable-line no-param-reassign
-  } else {
-    console.warn(`Listener does not exist for ${name}`); // eslint-disable-line no-console
   }
 
   dispatch({

src/utils/query.js

@@ -1,6 +1,6 @@
 import { attachListener, getQueryConfigs, firestoreRef } from '../../../src/utils/query';
 
-let dispatch;
+let dispatch = sinon.spy();
 let meta;
 let result;
 
@@ -10,6 +10,21 @@ describe('query utils', () => {
       expect(attachListener).to.be.a('function');
     });
 
+    it('converts slash path to dot path', () => {
+      attachListener({ _: { listeners: {} } }, dispatch, { collection: 'test' });
+      expect(dispatch).to.be.calledOnce;
+    });
+
+    it('throws if meta is not included', () => {
+      expect(() => attachListener({}, dispatch))
+        .to.Throw('Meta data is required to attach listener.');
+    });
+
+    it('throws if _ variable is not defined on Firebase', () => {
+      expect(() => attachListener({}, dispatch, { collection: 'test' }))
+        .to.Throw('Internal Firebase object required to attach listener. Confirm that reduxFirestore enhancer was added when you were creating your store');
+    });
+
     describe('converts slash path to dot path', () => {
       beforeEach(() => {
         dispatch = sinon.spy();