bug(reducers): documents with '.' (dot) character in their id are not correctly updated

[jeanregisser]

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

I'm listening to a subcollection like this:

firestoreConnect(({ userId }) => [{
  collection: `users/${userId}/favorites`,
  storeAs: 'favorites'
}])

The favorites are basically a collection of book ids.
The book ids contain the '.' (dot) character.

The initial LISTENER_RESPONSE populates the store correctly:

But then if I try to add another book as favorite:

firestore.set(`users/${userId}/favorites/${bookId}`, {
  savedAt: firestore.FieldValue.serverTimestamp(),
});

It breaks the data store:

Note that the ordered store is unaffected.

Also If I try to delete a favorite:

firestore.delete(`users/${userId}/favorites/${bookId}`);

It fails to delete it from the data store:

What is the expected behavior?

When listening to a collection with documents using the '.' (dot) characters in their id, it should correctly handle additions/updates/deletions in firestore.data.

Which versions of dependencies, and which browser are affected by this issue? Did this work in previous versions or setups?

This is happening with react-redux-firebase@2.1.6 and redux-firestore@0.5.7

This is within a React Native project 0.55.3 using react-native-firebase@4.1.0.

Steps to reproduce and if possible a minimal demo of the problem via codesandbox or similar.

[prescottprue]

Going to look into addressing this as part of the v1.0.0 releases. There isn't a solve for it yet, but the v1.0.0 Roadmap has been created to track changes.

[compojoom]

similar to that problem maybe? #88

[compojoom]

@jeanregisser - check my pull requests if you want. For me it seems to solve the storeAs problem.

[compojoom]

@prescottprue - please have a look at the pull request. I just did the same change in the case where there is no storeAs and meta.path

So far it looks good with our app.

[prescottprue]

Closed 427 of react-redux-firebase. Progress on fixing this will be tracked here