Composite storeAs broken since v0.7.1

[mic-css]

What is the current behavior?
Passing multiple queries with the same collection and storeAs values only returns the first query result.

What is the expected behavior?
The results from all queries should be merged into the same storeAs branch of the redux store as described in https://github.com/prescottprue/redux-firestore#where

// From v0.7.1 `state.firestore.data.onlineFriends === { [friendId]: 'sally' }`

['sally', 'john', 'peter'].map(friendId => ({
  collection: 'users',
  where: [
    ['id', '==', friendId],
    ['isOnline', '==', true]
  ]
  storeAs: 'onlineFriends'
}));

Which version of redux-firestore are you using? What about other dependencies?

redux-firestore: >= 0.7.1 // works in 0.7.0
react-redux-firebase: 2.2.6
redux: 4.0.1
firebase: 5.7.0
react: 16.5.0

It's unclear if this is deliberate as it goes against what the docs say. Potentially related to fixes implemented in v0.7.1 for #107

Thanks for all the great work on this library! 🙌

[prescottprue]

Definitely not intended, thanks for reporting

[DannyLingard]

I came across this bug as well. Any workarounds until patch released?

On another note using 'where' appears to store the doc as { [docId]: doc[docId]} but using docId() stores it as {...doc[docId]}. Is this expected?

Apologies, noob at code blocks in Github but as per below:

USING WHERE
state.firestore.data.onlineFriends === { [friendId]: users[firendId] }

['sally', 'john', 'peter'].map(friendId => ({
  collection: 'users',
  where: [
    ['id', '==', friendId],
    ['isOnline', '==', true]
  ]
  storeAs: 'onlineFriends'
}));

USING DOCID()
state.firestore.data.onlineFriends === { ...users[friendId] }

['sally', 'john', 'peter'].map(friendId => ({
  collection: 'users',
  docId(friendId),
  storeAs: 'onlineFriends'
}));``
`

[illuminist]

Workaround is to have different storeAs for each queries.

['sally', 'john', 'peter'].map(friendId => ({
  collection: 'users',
  where: [
    ['id', '==', friendId],
    ['isOnline', '==', true]
  ]
  storeAs: 'onlineFriends::' + friendId
}));

But keep in mine that even your query result is empty, firestore still will cost for one document read, which's just equal to reading by doc ref and do filter in client.

The better way should be having user doc contains a field array of userId who's friended with, then query with friend array instead, eg

{
  collection: 'users',
  where: [
    ['isFriendedWith', 'array-contains', currentUserId],
    ['isOnline', '==', true]
  ]
  storeAs: 'onlineFriends'
}

[w0nche0l]

Bumping this and also asking a question:

So what is the ideal way in redux-firestore to fetch a list of documents where you know their ids? such as ['sally', 'john', 'peter'] (assuming these are their firestore ids)