Handle errors during analysis (#3)

Author: presidentbeef

lib/brakeman-llm.rb

@@ -190,18 +190,22 @@ def run(options)
           $stderr.print " #{index}/#{total} warnings processed\r"
         end
 
-        if set_analysis
-          warning.llm_analysis = llm.analyze_warning(warning)
+        begin
+          if set_analysis
+            warning.llm_analysis = llm.analyze_warning(warning)
 
-          if disclaimer
-            warning.llm_analysis << "\n\n" << disclaimer
-          end
-        else
-          warning.message << "\n\n" << llm.analyze_warning(warning)
+            if disclaimer
+              warning.llm_analysis << "\n\n" << disclaimer
+            end
+          else
+            warning.message << "\n\n" << llm.analyze_warning(warning)
 
-          if disclaimer
-            warning.message << "\n\n" << disclaimer
+            if disclaimer
+              warning.message << "\n\n" << disclaimer
+            end
           end
+        rescue RubyLLM::Error => e
+          Brakeman.notify "Failed to analyze warning (#{warning.fingerprint}): #{e}"
         end
       end
 

test/test_basics.rb

@@ -157,4 +157,20 @@ def test_disclaimer_in_json
     chat_mock.verify
     response_mock.verify
   end
+
+  def test_error_during_analysis
+    bm_llm = Brakeman::LLM.new(model: 'test_model', provider: 'test_provider')
+    analysis = 'Extended warning description'
+    tracker = nil
+
+    chat_mock = -> (_) { raise RubyLLM::Error }
+
+    bm_llm.llm.stub(:chat, chat_mock) do
+      tracker = Brakeman.run(llm: { llm: bm_llm }, app_path: rails_app, output_format: :json)
+    end
+
+    tracker.warnings.each do |w|
+      assert_nil w.llm_analysis
+    end
+  end
 end