Skip to content

Commit 8712ba6

Browse files
authored
fix selecting dialect (#692)
1 parent 81fb552 commit 8712ba6

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

cmd/goose/main.go

-9
Original file line numberDiff line numberDiff line change
@@ -130,15 +130,6 @@ func main() {
130130
}
131131

132132
driver, dbstring, command := args[0], args[1], args[2]
133-
// To avoid breaking existing consumers. An implementation detail
134-
// that consumers should not care which underlying driver is used.
135-
switch driver {
136-
case "sqlite3":
137-
// Internally uses the CGo-free port of SQLite: modernc.org/sqlite
138-
driver = "sqlite"
139-
case "postgres", "redshift":
140-
driver = "pgx"
141-
}
142133
db, err := goose.OpenDBWithDriver(driver, normalizeDBString(driver, dbstring, *certfile, *sslcert, *sslkey))
143134
if err != nil {
144135
log.Fatalf("-dbstring=%q: %v\n", dbstring, err)

db.go

+7
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,20 @@ func OpenDBWithDriver(driver string, dbstring string) (*sql.DB, error) {
1212
return nil, err
1313
}
1414

15+
// To avoid breaking existing consumers. An implementation detail
16+
// that consumers should not care which underlying driver is used.
1517
switch driver {
1618
case "mssql":
1719
driver = "sqlserver"
1820
case "tidb":
1921
driver = "mysql"
2022
case "turso":
2123
driver = "libsql"
24+
case "sqlite3":
25+
// Internally uses the CGo-free port of SQLite: modernc.org/sqlite
26+
driver = "sqlite"
27+
case "postgres", "redshift":
28+
driver = "pgx"
2229
}
2330

2431
switch driver {

0 commit comments

Comments
 (0)