Skip to content

Commit 1301620

Browse files
committed
Fork Presto ES connector for continued ES 6 support
Upgrading the Presto Elasticsearch connector to use Elasticsearch 7.0 libraries will introduce breaking changes for supporting Elasticsearch 6.0 servers due to the lack of backward compatibility in the Elasticsearch v7.0 RestHighLevelClient (HLC) and the Types deprecated in APIs in ES 7.0 introducing breaking changes to the index creation, put mapping, get mapping, put template, get template and get field mappings APIs. By forking and creating a presto-elasticsearch-6 version of the Elasticsearch connector as a new module we can mitigate these breaking changes so users can stay using the older connector code if they need to stay on the older ES 6.x servers. As it's own module we can release this independently and provide instructions for users to retain ES6 access. If it goes as a submodule in the main Presto repository it can cause issues with CI and the versioning won't make sense since it would follow Presto's versioning, when as a standalone plugin it should be versioned independently. The existing presto-elasticsearch module source, tests, and config files were copied, renamed to presto-elasticsearch-6 and copied thi new repository. Update the name of the plugin to ElasticsearchLegacyPlugin and the connector name to elasticsearch_legacy to avoid conflicts.
1 parent ce59fde commit 1301620

File tree

69 files changed

+7761
-0
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+7761
-0
lines changed

.github/workflows/maven.yml

+30
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow execution time
2+
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-maven
3+
4+
name: Java CI with Maven
5+
6+
on:
7+
push:
8+
branches: [ "main" ]
9+
pull_request:
10+
branches: [ "main" ]
11+
12+
jobs:
13+
build:
14+
15+
runs-on: ubuntu-latest
16+
17+
steps:
18+
- uses: actions/checkout@v4
19+
with:
20+
show-progress: false
21+
# needed for the git-commit-id-plugin to work
22+
fetch-depth: 0
23+
- name: Set up JDK 8
24+
uses: actions/setup-java@v3
25+
with:
26+
java-version: '8'
27+
distribution: 'temurin'
28+
cache: maven
29+
- name: Maven verify
30+
run: mvn verify

0 commit comments

Comments
 (0)