From 14354052fd13e38189f09fbf1579c3caadf8bb5b Mon Sep 17 00:00:00 2001
From: Zac Blanco <zac@ibm.com>
Date: Fri, 6 Jun 2025 15:11:20 -0700
Subject: [PATCH] Add Router as a valid section header

---
 .../tasks/GenerateReleaseNotesTask.java       |  1 +
 .../tasks/TestCheckReleaseNotesTask.java      | 22 +++++++++----------
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/presto-release-tools/src/main/java/com/facebook/presto/release/tasks/GenerateReleaseNotesTask.java b/presto-release-tools/src/main/java/com/facebook/presto/release/tasks/GenerateReleaseNotesTask.java
index 6512d7f..a7405fb 100644
--- a/presto-release-tools/src/main/java/com/facebook/presto/release/tasks/GenerateReleaseNotesTask.java
+++ b/presto-release-tools/src/main/java/com/facebook/presto/release/tasks/GenerateReleaseNotesTask.java
@@ -90,6 +90,7 @@ public class GenerateReleaseNotesTask
     public static final List<Pattern> VALID_SECTION_HEADERS = ImmutableList.of(
                     "^General.*",
                     "^Prestissimo \\(Native Execution\\)",
+                    "^Router",
                     "^Security",
                     "^JDBC Driver",
                     "^Web UI",
diff --git a/presto-release-tools/src/test/java/com/facebook/presto/release/tasks/TestCheckReleaseNotesTask.java b/presto-release-tools/src/test/java/com/facebook/presto/release/tasks/TestCheckReleaseNotesTask.java
index f64cc91..bb133a2 100644
--- a/presto-release-tools/src/test/java/com/facebook/presto/release/tasks/TestCheckReleaseNotesTask.java
+++ b/presto-release-tools/src/test/java/com/facebook/presto/release/tasks/TestCheckReleaseNotesTask.java
@@ -76,6 +76,7 @@ public Object[][] sectionHeaders()
                 {"General"},
                 {"Prestissimo (Native Execution)"},
                 {"Security"},
+                {"Router"},
                 {"JDBC Driver"},
                 {"Web UI"},
                 {"Sample Connector"},
@@ -102,23 +103,22 @@ public Object[][] releaseNotesFailures()
                 // no edit to template
                 {Resources.toString(Resources.getResource("note_template.md"), StandardCharsets.UTF_8)},
                 // ambiguous, double release note blocks
-                {"== RELEASE NOTES ==\n changes\n* asdasd\n\n\n== NO RELEASE NOTES =="},
+                {"== RELEASE NOTES ==\n changes\n* Fix a thing\n\n\n== NO RELEASE NOTES =="},
                 // release note vs notes
-                {"== RELEASE NOTES ==\ngeneral\n* asd\n\n== RELEASE NOTE ==\ngeneral\n* asd"},
-                {"== RELEASE NOTES ==\ngeneral\n* asd\n\n== RELEASE NOTES ==\ngeneral\n* asd"},
+                {"== RELEASE NOTES ==\ngeneral\n* Fix a thing\n\n== RELEASE NOTE ==\ngeneral\n* Fix a thing"},
+                {"== RELEASE NOTES ==\ngeneral\n* Fix a thing\n\n== RELEASE NOTES ==\ngeneral\n* Fix a thing"},
                 // invalid section titles
-                {"== RELEASE NOTES ==\n\ngenerel chang\ntest"},
-                {"== RELEASE NOTES ==\n\ngeneral changes\ntest"},
-                {"== RELEASE NOTES ==\n\ncustom section\n* test"},
+                {"== RELEASE NOTES ==\n\ngenerel chang\n* Fix a thing"},
+                {"== RELEASE NOTES ==\n\ncustom changes\n* Fix a thing"},
                 // invalid note starts
                 {"== RELEASE NOTES ==\n\nGeneral Changes\n* test a thing"},
-                {"== RELEASE NOTES ==\n\nGeneral Changes\ntest a thing"},
-                {"== RELEASE NOTES ==\n\nGeneral Changes\n* Add test a thing\n* enhance a thing"},
+                {"== RELEASE NOTES ==\n\nGeneral Changes\nFix a thing"},
+                {"== RELEASE NOTES ==\n\nGeneral Changes\n* Fix a thing\n* enhance a thing"},
                 // multiple sections, one invalid section title
-                {"== RELEASE NOTES ==\n\nGeneral Changes\n* Add test a thing\n\nSNI changes\n* Add an SPI thing"},
+                {"== RELEASE NOTES ==\n\nGeneral Changes\n* Fix a thing\n\nSNI changes\n* Add an SPI thing"},
                 // multiple sections one invalid release note verb
-                {"== RELEASE NOTES ==\n\nGeneral Changes\n* Add test a thing\n\nSPI changes\n* bump version of an SPI thing"},
-                {"== RELEASE NOTES ==\n\nPrestissimo Native Execution Changes\n* Add test a thing\n\nSPI changes\n* bump version of an SPI thing"},
+                {"== RELEASE NOTES ==\n\nGeneral Changes\n* Fix a thing\n\nSPI changes\n* bump version of an SPI thing"},
+                {"== RELEASE NOTES ==\n\nPrestissimo Native Execution Changes\n* Fix a thing\n\nSPI changes\n* bump version of an SPI thing"},
         };
     }