Skip to content

Improve error message when performing update/merge operations via prestissimo engine #28027

Description

@michalbialozyt

Expected Behavior or Use Case

Currently, when trying to run update or merge statement on prestissimo engine via presto JDBC driver, the returned error message is:

com.facebook.presto.spi.PrestoException: Expected response code from https://prestissimo-worker-1..svc.cluster.local:7443/v1/task/20260619.1.0.0.0?summarize to be 200, but was 500: 
        com.facebook.presto.sql.planner.plan.UpdateNode no abstract type PlanNode 
        at com.facebook.presto.server.SimpleHttpResponseHandler.onSuccess(SimpleHttpResponseHandler.java:67)
        at com.facebook.presto.server.SimpleHttpResponseHandler.onSuccess(SimpleHttpResponseHandler.java:30)
        at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1133)
        at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)
        at com.facebook.presto.execution.SafeEventLoopGroup$SafeEventLoop.run(SafeEventLoopGroup.java:74)
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:998)
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at java.base/java.lang.Thread.run(Thread.java:840)

This error message may leave users in confusion. Throwing a dedicated exception stating that presto-cpp engine does not support update operations would improve readability and make error-handling much easier.

Presto Component, Service, or Connector

Possible Implementation

Example Screenshots (if appropriate):

Context

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions