Fix infinite loop in order cleanup

raphaelm · robbi5 · commit 1c968faebcd1 · 2025-06-16T12:15:07.000+02:00
diff --git a/libpretixsync/src/main/java/eu/pretix/libpretixsync/sync/OrderCleanup.kt b/libpretixsync/src/main/java/eu/pretix/libpretixsync/sync/OrderCleanup.kt
@@ -86,7 +86,7 @@ class OrderCleanup(val store: BlockingEntityStore<Persistable>, val fileStorage:
                         deltime = System.currentTimeMillis()
                     }
                     for (sId in subeventIds) {
-                        if (sId == null) {
+                        if (sId == null || sId == 0L) {
                             deltime = System.currentTimeMillis() + 1000L * 3600 * 24 * 365 * 20 // should never happen, if it does, don't delete this any time soon
                             break
                         }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ class OrderCleanup(val store: BlockingEntityStore<Persistable>, val fileStorage:`
`86`	`86`	`deltime = System.currentTimeMillis()`
`87`	`87`	`}`
`88`	`88`	`for (sId in subeventIds) {`
`89`		`- if (sId == null) {`
	`89`	`+ if (sId == null \|\| sId == 0L) {`
`90`	`90`	`deltime = System.currentTimeMillis() + 1000L * 3600 * 24 * 365 * 20 // should never happen, if it does, don't delete this any time soon`
`91`	`91`	`break`
`92`	`92`	`}`