Use IllegalArgumentException for PostgresIdAdapter

antweb · antweb · commit b1a795ea550b · 2024-07-31T11:09:53.000+02:00
It's a better fit than IllegalStateException.
diff --git a/libpretixsync/src/main/java/eu/pretix/libpretixsync/sqldelight/PostgresIdAdapter.kt b/libpretixsync/src/main/java/eu/pretix/libpretixsync/sqldelight/PostgresIdAdapter.kt
@@ -17,7 +17,7 @@ class PostgresIdAdapter : ColumnAdapter<Long, Int> {
 
     override fun encode(value: Long): Int {
         if (value < Int.MIN_VALUE || value > Int.MAX_VALUE) {
-            throw IllegalStateException("ID value exceeds integer range")
+            throw IllegalArgumentException("ID value exceeds integer range")
         }
 
         return value.toInt()

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ class PostgresIdAdapter : ColumnAdapter<Long, Int> {`
`17`	`17`
`18`	`18`	`override fun encode(value: Long): Int {`
`19`	`19`	`if (value < Int.MIN_VALUE \|\| value > Int.MAX_VALUE) {`
`20`		`- throw IllegalStateException("ID value exceeds integer range")`
	`20`	`+ throw IllegalArgumentException("ID value exceeds integer range")`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`return value.toInt()`