Migrate Question validation tests

Author: antweb

libpretixsync/src/main/sqldelight/common/eu/pretix/libpretixsync/sqldelight/Question.sq

@@ -3,6 +3,11 @@ SELECT *
 FROM Question
 WHERE server_id = ?;
 
+selectByEventSlug:
+SELECT *
+FROM Question
+WHERE event_slug = ?;
+
 selectForItem:
 SELECT Question.*
 FROM Question

libpretixsync/src/test/java/eu/pretix/libpretixsync/db/QuestionAnswerRequiredValidationTest.kt

@@ -1,17 +1,27 @@
 package eu.pretix.libpretixsync.db
 
+import eu.pretix.libpretixsync.check.QuestionType
 import org.junit.Assert.fail
 import org.junit.Test
+import eu.pretix.libpretixsync.models.Question as QuestionModel
 
 
 class QuestionAnswerRequiredValidationTest {
 
     @Test
     @Throws(QuestionLike.ValidationException::class)
     fun testBoolean() {
-        val q = Question()
-        q.isRequired = true
-        q.setJson_data("{\"id\":1,\"question\":{\"en\":\"Test\"},\"type\":\"B\",\"required\":true,\"items\":[1],\"options\":[],\"position\":0,\"ask_during_checkin\":false,\"identifier\":\"ABTBAB8S\",\"dependency_question\":null,\"dependency_value\":null}")
+        val q = QuestionModel(
+            question = "Test",
+            type = QuestionType.B,
+            required = true,
+            identifier = "ABTBAB8S",
+            eventSlug = "test",
+            id = 1L,
+            serverId = 1L,
+            position = 0L,
+        )
+
         q.clean_answer("True", q.options, false)
 
         try {
@@ -24,9 +34,17 @@ class QuestionAnswerRequiredValidationTest {
 
     @Test
     fun testBooleanWithOptionalOverride() {
-        val q = Question()
-        q.isRequired = true
-        q.setJson_data("{\"id\":1,\"question\":{\"en\":\"Test\"},\"type\":\"B\",\"required\":true,\"items\":[1],\"options\":[],\"position\":0,\"ask_during_checkin\":false,\"identifier\":\"ABTBAB8S\",\"dependency_question\":null,\"dependency_value\":null}")
+        val q = QuestionModel(
+            question = "Test",
+            type = QuestionType.B,
+            required = true,
+            identifier = "ABTBAB8S",
+            eventSlug = "test",
+            id = 1L,
+            serverId = 1L,
+            position = 0L,
+        )
+
         try {
             q.clean_answer("False", q.options, true)
         } catch (e: QuestionLike.ValidationException) {
@@ -37,9 +55,17 @@ class QuestionAnswerRequiredValidationTest {
     @Test
     @Throws(QuestionLike.ValidationException::class)
     fun testText() {
-        val q = Question()
-        q.setJson_data("{\"id\":1,\"question\":{\"en\":\"Test\"},\"type\":\"T\",\"required\":true,\"items\":[1],\"options\":[],\"position\":0,\"ask_during_checkin\":false,\"identifier\":\"ABTBAB8S\",\"dependency_question\":null,\"dependency_value\":null}")
-        q.isRequired = true
+        val q = QuestionModel(
+            question = "Test",
+            type = QuestionType.T,
+            required = true,
+            identifier = "ABTBAB8S",
+            eventSlug = "test",
+            id = 1L,
+            serverId = 1L,
+            position = 0L,
+        )
+
         q.clean_answer("True", q.options, false)
         q.clean_answer("False", q.options, false)
         try {
@@ -51,9 +77,17 @@ class QuestionAnswerRequiredValidationTest {
 
     @Test
     fun testTextWithOptionalOverride() {
-        val q = Question()
-        q.setJson_data("{\"id\":1,\"question\":{\"en\":\"Test\"},\"type\":\"T\",\"required\":true,\"items\":[1],\"options\":[],\"position\":0,\"ask_during_checkin\":false,\"identifier\":\"ABTBAB8S\",\"dependency_question\":null,\"dependency_value\":null}")
-        q.isRequired = true
+        val q = QuestionModel(
+            question = "Test",
+            type = QuestionType.T,
+            required = true,
+            identifier = "ABTBAB8S",
+            eventSlug = "test",
+            id = 1L,
+            serverId = 1L,
+            position = 0L,
+        )
+
         try {
             q.clean_answer("", q.options, true)
         } catch (e: QuestionLike.ValidationException) {

libpretixsync/src/test/java/eu/pretix/libpretixsync/db/QuestionAnswerValidationTest.kt

@@ -6,15 +6,29 @@ import org.junit.Assert.fail
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
+import eu.pretix.libpretixsync.models.Question as QuestionModel
 
 
 @RunWith(Parameterized::class)
 class QuestionAnswerValidationTest(private val questionType: QuestionType, private val input: String, private val expected: String?) {
 
     @Test
     fun test() {
-        val q = Question()
-        q.setJson_data("{\"id\":1,\"question\":{\"en\":\"Test\"},\"type\":\"$questionType\",\"required\":false,\"items\":[1],\"options\":[{\"id\": 3, \"answer\": \"A\", \"position\": 2, \"identifier\": \"AAA1\"}, {\"id\": 12, \"answer\": \"B\", \"position\": 1, \"identifier\": \"BBB2\"}],\"position\":0,\"ask_during_checkin\":false,\"identifier\":\"ABTBAB8S\",\"dependency_question\":null,\"dependency_value\":null}")
+        val q = QuestionModel(
+            type = questionType,
+            required = false,
+            question = "Test",
+            identifier = "ABTBAB8S",
+            askDuringCheckIn = false,
+            options = listOf(
+                QuestionOption(3L, 2, "AAA1", "A"),
+                QuestionOption(12L, 1, "BBB2", "B"),
+            ),
+            id = 1L,
+            serverId = 1L,
+            eventSlug = "",
+            position = 0L,
+        )
 
         if (expected == null) {
             try {