feat: cleanup logging now that it's persisted

Author: kkostov

pretixscan/composeApp/src/commonMain/kotlin/eu/pretix/PretixModules.kt

@@ -15,6 +15,9 @@ import eu.pretix.libpretixsync.sync.FileStorage
 import eu.pretix.scan.tickets.data.PrintLayoutFetcher
 import org.koin.core.module.Module
 import org.koin.dsl.module
+import java.util.logging.Logger
+
+private val log = Logger.getLogger("PretixModules")
 
 
 val pretixModules: List<Module>
@@ -48,13 +51,13 @@ val pretixModules: List<Module>
                 val appCache = get<AppCache>()
 
                 if (config.proxyMode) {
-                    println("Resolving TicketCheckProvider in proxy mode")
+                    log.info("Resolving TicketCheckProvider in proxy mode")
                     ProxyCheckProvider(config, get<HttpClientFactory>())
                 } else if (config.offlineMode) {
-                    println("Resolving TicketCheckProvider in offline mode")
+                    log.info("Resolving TicketCheckProvider in offline mode")
                     AsyncCheckProvider(config, appCache.db)
                 } else {
-                    println("Resolving TicketCheckProvider in online mode")
+                    log.info("Resolving TicketCheckProvider in online mode")
                     OnlineCheckProvider(
                         config,
                         get<HttpClientFactory>(),

pretixscan/composeApp/src/commonMain/kotlin/eu/pretix/desktop/app/sync/SyncProgressView.kt

@@ -83,7 +83,6 @@ fun SyncedTimeAgo(never: Boolean, daysAgo: Int, hoursAgo: Int, minutesAgo: Int)
         }
 
         statusHelper.isDaysAgo() -> {
-            println("days ago ${statusHelper.daysAgo()}")
             Text(
                 pluralStringResource(
                     Res.plurals.sync_status_time_days,

pretixscan/composeApp/src/commonMain/kotlin/eu/pretix/desktop/app/sync/SyncRoot.kt

@@ -36,7 +36,6 @@ fun SyncRoot(
     }
 
     val showMainSyncProgress by viewModel.showMainSyncProgress.collectAsState()
-    println("Current sync state: $syncState")
 
     Box(Modifier.fillMaxSize()) {
         // render child content

pretixscan/composeApp/src/commonMain/kotlin/eu/pretix/desktop/app/ui/SimpleComboBox.kt

@@ -328,8 +328,6 @@ fun MenuScope.MenuContent(
                                         .startsWith(char.lowercase()))
                                 }
                                 if (matchingOption != null) {
-                                    val matchIndex = menuState.options.indexOf(matchingOption)
-                                    println("found match for $char at index ${matchIndex} for label ${matchingOption.label} and value ${matchingOption.value}, requesting focus")
                                     menuState.focusItem(matchingOption)
                                     true
                                 } else false

pretixscan/composeApp/src/commonMain/kotlin/eu/pretix/scan/main/presentation/MainViewModel.kt

@@ -34,7 +34,7 @@ class MainViewModel(
     val eventButtonTooltip = _eventButtonTooltip.asStateFlow()
 
     init {
-        println("Welcome to app version ${Version.version}. Current scan type is ${appConfig.scanType}.")
+        log.info("Welcome to app version ${Version.version}. Current scan type is ${appConfig.scanType}.")
 
         uiState
             .onEach { state ->

pretixscan/composeApp/src/commonMain/kotlin/eu/pretix/scan/tickets/data/ConnectivityHelper.kt

@@ -4,11 +4,11 @@ import eu.pretix.libpretixsync.sync.SyncManager
 
 class ConnectivityHelper : SyncManager.CheckConnectivityFeedback {
     override fun recordError() {
-        println("TODO: implement recording this error.")
+        // TODO: implement recording this error
     }
 
     override fun recordSuccess(durationInMillis: Long?) {
-        println("TODO: implement recording this success.")
+        // TODO: implement recording this success
     }
 
 }

pretixscan/composeApp/src/commonMain/kotlin/eu/pretix/scan/tickets/data/TicketCodeHandler.kt

@@ -19,6 +19,7 @@ import org.jetbrains.compose.resources.ExperimentalResourceApi
 import org.jetbrains.compose.resources.getString
 import pretixscan.composeapp.generated.resources.*
 import java.text.SimpleDateFormat
+import java.util.logging.Logger
 
 @OptIn(ExperimentalResourceApi::class)
 class TicketCodeHandler(
@@ -30,6 +31,7 @@ class TicketCodeHandler(
     private val connectivityHelper: ConnectivityHelper,
     private val layoutFetcher: PrintLayoutFetcher
 ) {
+    private val log = Logger.getLogger("TicketCodeHandler")
 
     suspend fun handleScanResult(
         rawResult: String?,
@@ -128,7 +130,7 @@ class TicketCodeHandler(
                 allowQuestions = allowQuestions
             )
 
-            println("Check result type: ${checkResult.type}")
+            log.info("Check result type: ${checkResult.type}")
 
             if (checkProvider is OnlineCheckProvider) {
                 if (checkResult.type == TicketCheckProvider.CheckResult.Type.ERROR) {

pretixscan/composeApp/src/commonMain/kotlin/eu/pretix/scan/tickets/presentation/QuestionsDialogViewModel.kt

@@ -191,7 +191,7 @@ class QuestionsDialogViewModel(private val config: DataStoreConfigStore) : ViewM
     fun updateChoiceAnswer(questionId: Long, value: String, checked: Boolean?) {
         _form.value = _form.value.map { field ->
             if (field.id == questionId && field.fieldType == QuestionType.M) {
-                log.info("Updating choices for $questionId (${field.fieldType}) value:checked $value:$checked")
+                log.info("Updating choices for $questionId (${field.fieldType})")
                 when (checked) {
                     true -> {
                         val updatedValues = (field.values?.toList()?.toMutableList()
@@ -211,7 +211,7 @@ class QuestionsDialogViewModel(private val config: DataStoreConfigStore) : ViewM
     fun updateAnswer(questionId: Long, answer: String?, extra: String? = null) {
         _form.value = _form.value.map { field ->
             if (field.id == questionId) {
-                log.info("Updating answer for $questionId (${field.fieldType}) to $answer, extra: $extra")
+                log.info("Updating answer for $questionId (${field.fieldType})")
 
                 when (field.fieldType) {
                     QuestionType.F -> {
@@ -284,7 +284,7 @@ class QuestionsDialogViewModel(private val config: DataStoreConfigStore) : ViewM
             }
         }
         _form.value.forEach { field ->
-            log.info("question ${field.label}: ${field.value}, valid: ${if (field.validation == null) "yes" else "${field.validation}"}")
+            log.info("question ${field.label}, valid: ${if (field.validation == null) "yes" else "${field.validation}"}")
         }
     }
 

pretixscan/composeApp/src/commonMain/kotlin/eu/pretix/scan/tickets/presentation/SearchResultsView.kt

@@ -64,7 +64,6 @@ fun SearchResultsView(
         ) {
             itemsIndexed(searchSuggestions) { index, item ->
                 FocusableRowItem(index, item, onSelectedSearchResult, onFocused = {
-                    println("Focused row $index")
                     focusedIndex.value = index
                 }, focusedIndex = focusedIndex.value)
             }

pretixscan/composeApp/src/commonMain/kotlin/eu/pretix/scan/tickets/presentation/TicketHandlingDialogViewModel.kt

@@ -26,7 +26,7 @@ class TicketHandlingDialogViewModel(
     }
 
     suspend fun handleTicket(secret: String?, answers: List<Answer>? = null, ignoreUnpaid: Boolean = false) {
-        log.info("Handling ticket $secret")
+        log.info("Handling ticket")
         _uiState.update {
             ResultStateData(resultState = ResultState.LOADING)
         }