feat: allow configuring the packageName at build time

Author: kkostov

.github/workflows/publish.yml

@@ -37,7 +37,8 @@ jobs:
 
       - name: Package App
         working-directory: ./pretixscan
-        run: ./gradlew packageDistributionForCurrentOS
+        shell: bash
+        run: ./gradlew packageDistributionForCurrentOS -PappPackageName="${{ runner.os == 'Windows' && 'pretixSCAN Desktop' || 'pretixSCAN' }}"
 
       - name: Read version
         working-directory: ./pretixscan

pretixscan/README.md

@@ -35,7 +35,7 @@ KMP provides for various native distributions to be created, please refer to the
 For example, create a distribution package for the current OS:
 
 ```bash
-./gradlew packageDistributionForCurrentOS
+./gradlew packageDistributionForCurrentOS -PappPackageName="pretixSCAN"
 ```
 
 By default, packages are created under `pretixscan/composeApp/build/compose/binaries`.

pretixscan/composeApp/build.gradle.kts

@@ -153,8 +153,13 @@ compose.desktop {
         mainClass = "eu.pretix.desktop.MainKt"
 
         nativeDistributions {
+            // On Windows, we need the packageName to be set as 'pretixSCAN Desktop' in order to avoid a conflict with v1
+
+            val requiredPackageName = findProperty("appPackageName")?.toString()
+                ?: throw GradleException("Package name must be provided via -PappPackageName=<name>")
+
             targetFormats(TargetFormat.Dmg, TargetFormat.Msi, TargetFormat.Deb)
-            packageName = "pretixSCAN"
+            packageName = requiredPackageName
             packageVersion = version
             vendor = "pretix GmbH"
             copyright = "pretix.eu, Raphael Michel"
@@ -167,8 +172,8 @@ compose.desktop {
             macOS {
                 iconFile.set(File("logo/pretix_app_icon.icns"))
             }
+
             windows {
-                packageName = "pretixSCAN Desktop"
                 iconFile.set(File("logo/pretix_app_icon.ico"))
 
                 // MSI specific configuration
@@ -182,6 +187,7 @@ compose.desktop {
                 upgradeUuid = "550e8400-e29b-41d4-a716-446655440000"
 
             }
+
             linux {
                 iconFile.set(File("logo/pretix_app_icon.png"))
             }