ci: add core prettier compatibility matrix

Author: mitermayer

.github/workflows/compatibility-smoke.yml

@@ -103,6 +103,76 @@ jobs:
       - name: Run known-passing formatting fixtures
         run: yarn test:formatting:passing
 
+  core-formatting:
+    name: Core formatting fixtures
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: yarn
+
+      - name: Install Vim
+        run: sudo apt-get update && sudo apt-get install -y vim
+
+      - name: Verify Vim capabilities
+        run: node scripts/vim-version.js
+
+      - name: Report Yarn version
+        run: yarn --version
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Run core formatting fixtures
+        run: yarn test:formatting:core
+
+  core-formatting-exec:
+    name: Core formatting fixtures with Prettier ${{ matrix.prettier-version }}
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        prettier-version:
+          - 2.8.8
+          - latest
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: yarn
+
+      - name: Install Vim
+        run: sudo apt-get update && sudo apt-get install -y vim
+
+      - name: Verify Vim capabilities
+        run: node scripts/vim-version.js
+
+      - name: Report Yarn version
+        run: yarn --version
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Install matrix Prettier
+        run: npm install --prefix "$RUNNER_TEMP/prettier-${{ matrix.prettier-version }}" "prettier@${{ matrix.prettier-version }}"
+
+      - name: Run core formatting fixtures with matrix Prettier
+        run: yarn test:formatting:core:exec
+        env:
+          PRETTIER_EXEC_CMD_PATH: ${{ runner.temp }}/prettier-${{ matrix.prettier-version }}/node_modules/.bin/prettier
+
   quarantined-formatting-discovery:
     name: Quarantined Lua/Ruby formatting discovery
     runs-on: ubuntu-latest

AGENTS.md

@@ -139,6 +139,20 @@ plugin versions:
   Docs now scope measured bundled fallback support to PHP/XML, classify Lua/Ruby
   bundled formatting as quarantined failing, and classify Svelte as detected but
   unmeasured under the current Prettier 3 baseline.
+- Added a core-only formatting fixture lane for CSS, GraphQL, HTML, JS, JSON,
+  Less, Markdown, SCSS, TS, Vue, and YAML so core formatter coverage is not mixed
+  with bundled external plugin languages.
+- The test harness can set `g:prettier#exec_cmd_path` from
+  `PRETTIER_EXEC_CMD_PATH`, allowing core fixtures to run against caller-provided
+  Prettier executables outside this checkout without changing package deps.
+- `yarn test:formatting:core` passes against the bundled/current Prettier 3.0.3
+  baseline, and `PRETTIER_EXEC_CMD_PATH=... yarn test:formatting:core:exec`
+  passes against a temp Prettier 2.8.8 install outside the repo.
+- Normalized the Markdown core fixture away from version-specific list
+  indentation and validated the core lane against temp Prettier 2.8.8 and
+  `prettier@latest` installs outside the repo.
+- Added a blocking CI core-formatting matrix for caller-provided Prettier 2.8.8
+  and latest executables outside this checkout.
 
 ## Review Findings After b538e29
 
@@ -178,8 +192,8 @@ plugin versions:
 - [x] Split Jest formatting tests into blocking known-passing and quarantined
   known-failing lanes.
 - [x] Harden CI with explicit Vim version/feature checks and `git diff --check`.
-- [ ] Add CI with an editor and Prettier compatibility matrix after smoke lanes
-  are stable.
+- [ ] Add CI with an editor compatibility matrix after smoke lanes are stable.
+- [x] Add CI with a Prettier core compatibility matrix.
 - [x] Resolve `vint` reproducibility through a pinned container or installable
   local deps.
 - [ ] Replace or deprecate the current Dockerfile path.
@@ -194,7 +208,10 @@ plugin versions:
   string, list, empty, invalid, and paths with spaces.
 - [x] Add project-local Prettier tests proving bundled plugin injection does not
   override local Prettier/plugins.
-- [ ] Validate core Prettier language fixtures on Prettier 2.8.8 and 3.x.
+- [x] Validate core Prettier language fixtures on bundled/current Prettier 3.0.3
+  and project-local Prettier 2.8.8.
+- [x] Decide the Prettier latest core snapshot strategy for the Markdown list
+  indentation delta before adding latest as a blocking target.
 - [x] Audit bundled parser-plugin versions for PHP, Ruby, XML, Lua, and Svelte.
 - [x] Decide Lua/Ruby/Svelte support policy together before advertising or
   removing any plugin-language support.
@@ -235,6 +252,8 @@ plugin versions:
 
 - `yarn install --frozen-lockfile`
 - `yarn test`
+- `yarn test:formatting:core`
+- `PRETTIER_EXEC_CMD_PATH=/path/to/prettier yarn test:formatting:core:exec`
 - `yarn lint`
 - `git diff --check`
 

package.json

@@ -9,10 +9,12 @@
     "url": "git://github.com/prettier/vim-prettier.git"
   },
   "scripts": {
-    "test": "node scripts/vim-version.js && LOG_LEVEL=error PRETTIER_FORMATTING_FIXTURE_LANE=all jest",
-    "test:smoke": "node scripts/vim-version.js && LOG_LEVEL=error PRETTIER_FORMATTING_FIXTURE_LANE=all jest tests/formatting.test.js --runInBand --testNamePattern=\"Prettier config|Prettier command shell\"",
-    "test:formatting:passing": "node scripts/vim-version.js && LOG_LEVEL=error PRETTIER_FORMATTING_FIXTURE_LANE=known-passing jest tests/formatting.test.js --runInBand",
-    "test:formatting:quarantined": "node scripts/vim-version.js && LOG_LEVEL=error PRETTIER_FORMATTING_FIXTURE_LANE=quarantined jest tests/formatting.test.js --runInBand",
+    "test": "node scripts/vim-version.js && PRETTIER_EXEC_CMD_PATH= LOG_LEVEL=error PRETTIER_FORMATTING_FIXTURE_LANE=all jest",
+    "test:smoke": "node scripts/vim-version.js && PRETTIER_EXEC_CMD_PATH= LOG_LEVEL=error PRETTIER_FORMATTING_FIXTURE_LANE=all jest tests/formatting.test.js --runInBand --testNamePattern=\"Prettier config|Prettier command shell\"",
+    "test:formatting:core": "node scripts/vim-version.js && PRETTIER_EXEC_CMD_PATH= LOG_LEVEL=error PRETTIER_FORMATTING_FIXTURE_LANE=core jest tests/formatting.test.js --runInBand",
+    "test:formatting:core:exec": "node scripts/vim-version.js && node -e \"if (!process.env.PRETTIER_EXEC_CMD_PATH) { console.error('Set PRETTIER_EXEC_CMD_PATH to a Prettier executable'); process.exit(1); }\" && LOG_LEVEL=error PRETTIER_FORMATTING_FIXTURE_LANE=core jest tests/formatting.test.js --runInBand",
+    "test:formatting:passing": "node scripts/vim-version.js && PRETTIER_EXEC_CMD_PATH= LOG_LEVEL=error PRETTIER_FORMATTING_FIXTURE_LANE=known-passing jest tests/formatting.test.js --runInBand",
+    "test:formatting:quarantined": "node scripts/vim-version.js && PRETTIER_EXEC_CMD_PATH= LOG_LEVEL=error PRETTIER_FORMATTING_FIXTURE_LANE=quarantined jest tests/formatting.test.js --runInBand",
     "lint": "sh scripts/vint.sh --version && sh scripts/vint.sh ."
   },
   "dependencies": {

tests/__snapshots__/formatting.test.js.snap

@@ -143,9 +143,7 @@ Lorem ipsum dolor amet
 
 ### bar
 
--   a
--   b
--   c"
+A short paragraph."
 `;
 
 exports[`Prettier formats foo.md file with :PrettierAsync command 1`] = `
@@ -155,9 +153,7 @@ Lorem ipsum dolor amet
 
 ### bar
 
--   a
--   b
--   c"
+A short paragraph."
 `;
 
 exports[`Prettier formats foo.php file with :Prettier command 1`] = `

tests/fixtures/foo.md

@@ -6,6 +6,4 @@ Lorem ipsum dolor amet
 
 
 
-- a 
-- b 
-- c
+A short paragraph.

tests/formatting.test.js

@@ -9,6 +9,19 @@ const PORT = 1337;
 const FIXTURES_DIR = `${__dirname}/fixtures`;
 const VIMRC = `${__dirname}/vimrc`;
 const FORMAT_FIXTURE_LANE = process.env.PRETTIER_FORMATTING_FIXTURE_LANE || 'all';
+const CORE_FORMATTING_FIXTURES = new Set([
+  'foo.css',
+  'foo.graphql',
+  'foo.html',
+  'foo.js',
+  'foo.json',
+  'foo.less',
+  'foo.md',
+  'foo.scss',
+  'foo.ts',
+  'foo.vue',
+  'foo.yaml',
+]);
 const QUARANTINED_FORMATTING_FIXTURES = new Set(['foo.lua', 'foo.rb']);
 const tempProjectRoots = [];
 
@@ -21,6 +34,10 @@ const isSelectedFormattingFixture = file => {
     return QUARANTINED_FORMATTING_FIXTURES.has(file);
   }
 
+  if (FORMAT_FIXTURE_LANE === 'core') {
+    return CORE_FORMATTING_FIXTURES.has(file);
+  }
+
   if (FORMAT_FIXTURE_LANE === 'all') {
     return true;
   }

tests/vimrc

@@ -2,6 +2,10 @@
 
 let s:plugin_root = fnamemodify(resolve(expand('<sfile>:p')), ':h:h')
 
+if exists('$PRETTIER_EXEC_CMD_PATH') && $PRETTIER_EXEC_CMD_PATH !=# ''
+    let g:prettier#exec_cmd_path = $PRETTIER_EXEC_CMD_PATH
+endif
+
 if filereadable('/rtp.vim')
     source /rtp.vim
 endif