fix: add compatibility smoke and plugin coverage

Author: mitermayer

.github/workflows/compatibility-smoke.yml

@@ -0,0 +1,59 @@
+name: Compatibility Smoke
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  smoke:
+    name: Targeted Vim smoke check
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: yarn
+
+      - name: Install Vim
+        run: sudo apt-get update && sudo apt-get install -y vim
+
+      - name: Report Yarn version
+        run: yarn --version
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Run targeted smoke check
+        run: yarn test:smoke
+
+  full-formatting-discovery:
+    name: Full formatting suite discovery
+    runs-on: ubuntu-latest
+    continue-on-error: true
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: yarn
+
+      - name: Install Vim
+        run: sudo apt-get update && sudo apt-get install -y vim
+
+      - name: Report Yarn version
+        run: yarn --version
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Run full formatting suite as discovery
+        run: yarn test

AGENTS.md

@@ -107,6 +107,17 @@ plugin versions:
   stored snapshots under the current Prettier 3.0.3 toolchain.
 - Remaining external plugin failures are no-op formatting for Lua, PHP, Ruby,
   and XML, consistent with stale or unresolved bundled parser plugins.
+- Added an initial GitHub Actions smoke workflow. It runs the Vim 9 config
+  version regression as a blocking check and runs the full formatting suite as
+  non-blocking discovery until plugin compatibility is restored.
+- Updated targeted Prettier 3.0.3 snapshots for GraphQL, SCSS, Vue, and YAML
+  after confirming those were core formatter deltas.
+- Added explicit `plugins` CLI config support and scoped automatic bundled
+  plugin loading for PHP and XML to Prettier executables under this checkout.
+  PHP and XML fixture tests now pass with the current bundled packages.
+- Lua and Ruby fixture tests still fail as no-op formatting. Current bundled Lua
+  and Ruby plugin versions are not viable Prettier 3 targets and need separate
+  support decisions before being advertised.
 
 ## Work Stages
 
@@ -121,13 +132,18 @@ plugin versions:
 
 ### Stage 1: Define Reproducible Tooling
 
+- [x] Add an initial CI smoke workflow for the known Vim 9 regression and
+  non-blocking full-suite discovery.
 - [ ] Add CI with an editor and Prettier compatibility matrix.
 - [ ] Decide whether lint runs from a pinned container or installable local deps.
 - [ ] Replace or deprecate the current Dockerfile path.
 - [ ] Document supported Node and package-manager versions.
 
 ### Stage 2: Prettier and Plugin Compatibility
 
+- [x] Update classified Prettier 3.0.3 core snapshots for GraphQL, SCSS, Vue,
+  and YAML without changing plugin-language snapshots broadly.
+- [x] Add explicit plugin argument support for PHP/XML bundled fallback tests.
 - [ ] Validate core Prettier language fixtures on Prettier 2.8.8 and 3.x.
 - [ ] Audit bundled parser-plugin versions for PHP, Ruby, XML, Lua, and Svelte.
 - [ ] Decide whether bundled plugin support remains in scope.

README.md

@@ -260,6 +260,10 @@ let g:prettier#config#use_tabs = 'auto'
 " default: ''
 let g:prettier#config#parser = ''
 
+" Prettier plugin paths to load. Accepts a string or list of strings.
+" default: []
+let g:prettier#config#plugins = []
+
 " cli-override|file-override|prefer-file
 " default: 'file-override'
 let g:prettier#config#config_precedence = 'file-override'

autoload/prettier/resolver/config.vim

@@ -106,6 +106,44 @@ function! s:Flag_parser(config_and_sel, ...) abort
   endif
 endfunction
 
+" Returns repeated '--plugin=PLUGIN' args or ''.
+function! s:Flag_plugins(config_and_sel, ...) abort
+  let l:value = get(
+          \ a:config_and_sel.config,
+          \ 'plugins',
+          \ get(g:, 'prettier#config#plugins', []))
+
+  if type(l:value) == type('')
+    let l:plugins = l:value ==# '' ? [] : [l:value]
+  elseif type(l:value) == type([])
+    let l:plugins = copy(l:value)
+  else
+    return ''
+  endif
+
+  if prettier#resolver#executable#isUnderPluginRoot(
+          \ prettier#resolver#executable#getPath())
+    let l:bundled_value = get(a:config_and_sel.config, 'bundledPlugins', [])
+
+    if type(l:bundled_value) == type('')
+      if l:bundled_value !=# ''
+        call add(l:plugins, l:bundled_value)
+      endif
+    elseif type(l:bundled_value) == type([])
+      call extend(l:plugins, l:bundled_value)
+    endif
+  endif
+
+  let l:flags = []
+  for l:plugin in l:plugins
+    if type(l:plugin) == type('') && l:plugin !=# ''
+      call add(l:flags, '--plugin=' . shellescape(l:plugin))
+    endif
+  endfor
+
+  return join(l:flags, ' ')
+endfunction
+
 " Returns '--stdin-filepath=' concatenated with the full path of the opened
 " file.
 function! s:Flag_stdin_filepath(...) abort
@@ -160,6 +198,11 @@ let s:FLAGS = {
         \   'json_name': 'parser',
         \   'global_name': 'parser',
         \   'mapper': function('s:Flag_parser')},
+        \ '--plugin': {
+        \   'json_name': 'plugins',
+        \   'global_name': 'plugins',
+        \   'mapper': function('s:Flag_plugins'),
+        \   'since': '1.10.0'},
         \ '--range-start': {
         \   'json_name': '',
         \   'global_name': '',

autoload/prettier/resolver/executable.vim

@@ -1,4 +1,24 @@
 let s:ROOT_DIR = fnamemodify(resolve(expand('<sfile>:p')), ':h')
+let s:PLUGIN_ROOT_DIR = fnamemodify(s:ROOT_DIR, ':h:h:h')
+
+function! s:NormalizePath(path) abort
+  let l:path = substitute(a:path, '\\ ', ' ', 'g')
+  return substitute(resolve(fnamemodify(l:path, ':p')), '\\', '/', 'g')
+endfunction
+
+function! prettier#resolver#executable#isUnderPluginRoot(path) abort
+  if type(a:path) != type('') || a:path ==# ''
+    return 0
+  endif
+
+  if a:path !~# '^\(/\|[A-Za-z]:[/\\]\)'
+    return 0
+  endif
+
+  let l:plugin_root = s:NormalizePath(s:PLUGIN_ROOT_DIR)
+  let l:path = s:NormalizePath(a:path)
+  return l:path ==# l:plugin_root || stridx(l:path, l:plugin_root . '/') ==# 0
+endfunction
 
 " By default we will search for the following
 " => user defined prettier cli path from vim configuration file

doc/prettier.txt

@@ -193,6 +193,10 @@ However they can be configured by:
   " default: ''
   let g:prettier#config#parser = ''
 
+  " Prettier plugin paths to load. Accepts a string or list of strings.
+  " default: []
+  let g:prettier#config#plugins = []
+
   " cli-override|file-override|prefer-file
   " default: 'file-override'
   let g:prettier#config#config_precedence = 'file-override'

ftplugin/php.vim

@@ -1,3 +1,10 @@
+let s:ROOT_DIR = fnamemodify(resolve(expand('<sfile>:p')), ':h:h')
+let s:plugin_path = s:ROOT_DIR . '/node_modules/@prettier/plugin-php/src/index.js'
+
 let b:prettier_ft_default_args = {
   \ 'parser': 'php',
   \ }
+
+if filereadable(s:plugin_path)
+  let b:prettier_ft_default_args['bundledPlugins'] = [s:plugin_path]
+endif

ftplugin/xml.vim

@@ -1,7 +1,14 @@
 " markdown/php files run this as well
 " https://stackoverflow.com/questions/22839269/why-does-vim-default-markdown-ftplugin-source-html-ftplugins-is-there-any-ways
 if expand('%:e') ==# 'xml'
+  let s:ROOT_DIR = fnamemodify(resolve(expand('<sfile>:p')), ':h:h')
+  let s:plugin_path = s:ROOT_DIR . '/node_modules/@prettier/plugin-xml/src/plugin.js'
+
   let b:prettier_ft_default_args = {
     \ 'parser': 'xml',
     \ }
+
+  if filereadable(s:plugin_path)
+    let b:prettier_ft_default_args['bundledPlugins'] = [s:plugin_path]
+  endif
 endif

package.json

@@ -9,7 +9,8 @@
     "url": "git://github.com/prettier/vim-prettier.git"
   },
   "scripts": {
-    "test": "vim --version && LOG_LEVEL=error jest",
+    "test": "node scripts/vim-version.js && LOG_LEVEL=error jest",
+    "test:smoke": "node scripts/vim-version.js && LOG_LEVEL=error jest tests/formatting.test.js --runInBand --testNamePattern=\"Prettier config version detection works inside vim-driver execute\"",
     "lint": "vint --version && vint ."
   },
   "dependencies": {

plugin/prettier.vim

@@ -79,6 +79,9 @@ let g:prettier#config#use_tabs = get(g:,'prettier#config#use_tabs', 'auto')
 " See more: https://prettier.io/docs/en/options.html#parser
 let g:prettier#config#parser = get(g:,'prettier#config#parser', '')
 
+" Prettier plugin paths to load. Accepts a string or list of strings.
+let g:prettier#config#plugins = get(g:, 'prettier#config#plugins', [])
+
 " cli-override|file-override|prefer-file
 " default: 'file-override'
 " See more: https://prettier.io/docs/en/cli.html#--config-precedence