Skip to content

Commit b5a9114

Browse files
committed
modify name format w/ SN
1 parent 04e88a6 commit b5a9114

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

app/src/androidTest/java/com/prey/PreyConfigTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ public void givenMdmDeviceNameSet_whenBuildingName_thenMdmNameIsUsed() {
353353
// Arrange
354354
PreyConfig preyConfig = PreyConfig.getPreyConfig(context);
355355
preyConfig.setMdmDeviceName("Office Phone 001");
356-
preyConfig.setMdmSerialNumber("R8YX100J1WN");
356+
preyConfig.setMdmSerialNumber("R1YX100J1ON");
357357

358358
// Act
359359
String result = preyConfig.buildDeviceName("samsung SM-A145R");
@@ -365,7 +365,7 @@ public void givenMdmDeviceNameSet_whenBuildingName_thenMdmNameIsUsed() {
365365

366366
/**
367367
* Verifies that when no MDM device name is set but a serial number is available,
368-
* the device name is built as "defaultName - SN serialNumber".
368+
* the device name is built as "defaultName - serialNumber".
369369
*
370370
* <p><b>Scenario:</b> MDM provides a serial number but no custom device name.
371371
*
@@ -376,14 +376,14 @@ public void givenSerialNumberOnly_whenBuildingName_thenNameIncludesSerialNumber(
376376
// Arrange
377377
PreyConfig preyConfig = PreyConfig.getPreyConfig(context);
378378
preyConfig.setMdmDeviceName("");
379-
preyConfig.setMdmSerialNumber("R8YX100J1WN");
379+
preyConfig.setMdmSerialNumber("R1YX100J1ON");
380380

381381
// Act
382382
String result = preyConfig.buildDeviceName("samsung SM-A145R");
383383

384384
// Assert
385385
assertEquals("Device name should include serial number suffix",
386-
"samsung SM-A145R - SN R8YX100J1WN", result);
386+
"samsung SM-A145R - R1YX100J1ON", result);
387387
}
388388

389389
/**

app/src/main/java/com/prey/PreyConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1753,7 +1753,7 @@ public String buildDeviceName(String defaultName) {
17531753
}
17541754
String serialNumber = getMdmSerialNumber();
17551755
if (serialNumber != null && !"".equals(serialNumber)) {
1756-
return defaultName + " - SN " + serialNumber;
1756+
return defaultName + " - " + serialNumber;
17571757
}
17581758
return defaultName;
17591759
}

app/src/test/java/com/prey/PreyConfigRobolectricTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ public void givenNoOrganizationId_whenRetrieved_thenReturnsEmptyString() {
130130
@Test
131131
public void givenMdmDeviceNameSet_whenBuildingName_thenMdmNameIsUsed() {
132132
preyConfig.setMdmDeviceName("Office Phone 001");
133-
preyConfig.setMdmSerialNumber("R8YX100J1WN");
133+
preyConfig.setMdmSerialNumber("R1YX100J1ON");
134134

135135
String result = preyConfig.buildDeviceName("samsung SM-A145R");
136136

@@ -139,11 +139,11 @@ public void givenMdmDeviceNameSet_whenBuildingName_thenMdmNameIsUsed() {
139139

140140
@Test
141141
public void givenSerialNumberOnly_whenBuildingName_thenNameIncludesSerialNumber() {
142-
preyConfig.setMdmSerialNumber("R8YX100J1WN");
142+
preyConfig.setMdmSerialNumber("R1YX100J1ON");
143143

144144
String result = preyConfig.buildDeviceName("samsung SM-A145R");
145145

146-
assertEquals("samsung SM-A145R - SN R8YX100J1WN", result);
146+
assertEquals("samsung SM-A145R - R1YX100J1ON", result);
147147
}
148148

149149
@Test

0 commit comments

Comments
 (0)