Skip to content

EdDsa support broke source compatibility #43

Description

@fiadliel

I'm not sure if it's too late to yank 0.5.2, but it broke pattern matching on JsonWebKey. Ideally this would be released in a 0.6.

error[E0004]: non-exhaustive patterns: `&JsonWebKey::Okp(_)` not covered
   --> ....
    |
312 |     let decoding_key = match key {
    |                              ^^^ pattern `&JsonWebKey::Okp(_)` not covered
    |
note: `JsonWebKey` defined here
   --> .../jwks_client_rs-0.5.2/src/keyset.rs:45:1
    |
45  | pub enum JsonWebKey {
    | ^^^^^^^^^^^^^^^^^^^
...
51  |     Okp(OkpPublicJwk),
    |     --- not covered
    = note: the matched value is of type `&JsonWebKey`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
    |
319 ~         })?,
320 ~         &JsonWebKey::Okp(_) => todo!(),
    |

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions