Skip to content

Commit 0af26bd

Browse files
authored
Merge branch 'main' into stamat/remove-icon-lazyloading-from-eyebrow-banner
2 parents 8c0ab16 + 392d4c4 commit 0af26bd

File tree

5 files changed

+18
-0
lines changed

5 files changed

+18
-0
lines changed

.changeset/gentle-wolves-vanish.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react-brand': patch
3+
---
4+
5+
Adds hover states to the social icon links in MinimalFooter

packages/design-tokens/src/tokens/functional/components/footer/colors.json

+6
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66
"value": "var(--base-color-scale-white)",
77
"dark": "var(--base-color-scale-gray-9)"
88
}
9+
},
10+
"socialIcon": {
11+
"hoverFilter": {
12+
"value": "brightness(0)",
13+
"dark": "brightness(2)"
14+
}
915
}
1016
}
1117
}

packages/react/src/MinimalFooter/MinimalFooter.module.css

+5
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,11 @@
5959
padding-bottom: var(--base-size-48);
6060
}
6161

62+
.Footer__social-link:hover .Footer__social-icon,
63+
.Footer__social-link:focus-visible .Footer__social-icon {
64+
filter: var(--brand-footer-socialIcon-hoverFilter);
65+
}
66+
6267
.Footer__social-icon {
6368
width: 24px;
6469
height: auto;

packages/react/src/MinimalFooter/MinimalFooter.module.css.d.ts

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ declare const styles: {
66
readonly "Footer__social-links": string;
77
readonly "Footer__logomarks": string;
88
readonly "Footer__legal-and-links": string;
9+
readonly "Footer__social-link": string;
910
readonly "Footer__social-icon": string;
1011
readonly "Footer__copyright": string;
1112
readonly "Footer__links": string;

packages/react/src/MinimalFooter/MinimalFooter.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,7 @@ function SocialLogomarks({socialLinks, logoHref}: SocialLogomarksProps) {
229229
<li key={link.name}>
230230
<a
231231
href={link.url}
232+
className={styles['Footer__social-link']}
232233
data-analytics-event={`{"category":"Footer","action":"go to ${link.fullName}","label":"text:${link.name}"}`}
233234
>
234235
<img

0 commit comments

Comments
 (0)