ActionMenu falsy value bugfix (#912)

* allow falsey values to trigger item selection callback

* add a test to assert that falsey items can be selected

* add changeset

Author: joshfarrant

.changeset/kind-years-repair.md

@@ -0,0 +1,5 @@
+---
+'@primer/react-brand': patch
+---
+
+Fixed a bug in the `ActionMenu` component where items with falsy values (eg `""`) would not trigger the `onSelect` callback when selected.

packages/react/src/ActionMenu/ActionMenu.test.tsx

@@ -349,4 +349,23 @@ describe('ActionMenu', () => {
       {timeout: 100},
     )
   })
+
+  it('should allow falsey items to be selected', () => {
+    const mockOnSelect = jest.fn()
+
+    const {getByRole} = render(
+      <ActionMenu onSelect={mockOnSelect} selectionVariant="single">
+        <ActionMenu.Button>Open menu</ActionMenu.Button>
+        <ActionMenu.Overlay aria-label="Actions">
+          <ActionMenu.Item value="test">Test string</ActionMenu.Item>
+          <ActionMenu.Item value="">Empty string</ActionMenu.Item>
+        </ActionMenu.Overlay>
+      </ActionMenu>,
+    )
+
+    fireEvent.click(getByRole('button', {name: 'Open menu'}))
+    fireEvent.click(getByRole('menuitemradio', {name: 'Empty string'}))
+
+    expect(mockOnSelect).toHaveBeenCalledWith('')
+  })
 })

packages/react/src/ActionMenu/ActionMenu.tsx

@@ -166,11 +166,9 @@ const _ActionMenuRoot = memo(
 
     const handleItemSelection = useCallback(
       (newValue: string) => {
-        if (newValue) {
-          handleOnSelect(newValue)
-          toggleMenu()
-          anchorElementRef.current?.focus()
-        }
+        handleOnSelect(newValue)
+        toggleMenu()
+        anchorElementRef.current?.focus()
       },
       [handleOnSelect, toggleMenu, anchorElementRef],
     )