Skip to content

Commit 98fa3a2

Browse files
authored
fixed react 19 errors (#690)
* fixed react 19 errors * add changeset * remove previous changeset * fix typo
1 parent aff5874 commit 98fa3a2

File tree

4 files changed

+29
-10
lines changed

4 files changed

+29
-10
lines changed

.changeset/late-badgers-lay.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react-brand': minor
3+
---
4+
5+
Improved React 19 compatibility by treating `react-dom/client` and `react/jsx-runtime` as external dependencies of the project. This change resolved a reported conflict with the latest React 19 release candidate.

package-lock.json

+8-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@
8080
"webpack-cli": "^4.10.0"
8181
},
8282
"peerDependencies": {
83-
"react": ">=17 <= 18",
84-
"react-dom": ">=17 <= 18"
83+
"react": ">=17 <20",
84+
"react-dom": ">=17 <20"
8585
},
8686
"engines": {
8787
"node": ">=16.0.0",

packages/react/webpack.config.js

+14
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,25 @@ module.exports = {
1717
root: 'React',
1818
commonjs2: 'react',
1919
commonjs: 'react',
20+
amd: 'react',
2021
},
2122
'react-dom': {
2223
root: 'ReactDOM',
2324
commonjs2: 'react-dom',
2425
commonjs: 'react-dom',
26+
amd: 'react-dom',
27+
},
28+
'react-dom/client': {
29+
root: 'ReactDOMClient',
30+
commonjs2: 'react-dom/client',
31+
commonjs: 'react-dom/client',
32+
amd: 'react-dom/client',
33+
},
34+
'react/jsx-runtime': {
35+
root: 'ReactJSXRuntime',
36+
commonjs2: 'react/jsx-runtime',
37+
commonjs: 'react/jsx-runtime',
38+
amd: 'react/jsx-runtime',
2539
},
2640
},
2741
mode: 'production',

0 commit comments

Comments
 (0)