Skip to content

Commit f3a70ed

Browse files
authored
[Brand Refactor] Multiple component + recipe updates (#1363)
* LOTS of design adjustments * adding disableANimation prop * fix animation for toggle * increase test coverage * upgrade playwright dep * use local chrome * change chevrons to triangles and address feedback * fix tests
1 parent a4e6742 commit f3a70ed

252 files changed

Lines changed: 1312 additions & 233 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.changeset/add-base-size-tokens.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
---
2+
'@primer/brand-primitives': patch
3+
'@primer/react-brand': patch
4+
'@primer/brand-css': patch
5+
---
6+
7+
Added the `--base-size-60` and `--base-size-88` base size tokens.
8+
9+
Also exposed `60` and `88` through React components that use the base size scale, such as `Box` and `Stack`.
10+
11+
```tsx
12+
<Box padding={60} />
13+
<Box padding={88} />
14+
<Stack gap={60} />
15+
<Stack gap={88} />
16+
```
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react-brand': patch
3+
---
4+
5+
Disabled feature-list accordion animations in `PricingOptions` now that the intrinsic accordion includes a default animation.
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
'@primer/react-brand': patch
3+
'@primer/brand-css': patch
4+
---
5+
6+
- Updated the `Accordion` toggle indicator to use the `TriangleDownIcon` octicon, which rotates anti-clockwise between its open and closed states.
7+
8+
- Improved `Accordion` content open and close animation so items transition using measured content height.
9+
10+
- Added a `disableAnimation` prop to `Accordion` now that it includes a default animation, which may not be applicable in all use-cases.
11+
12+
- Updated `Accordion` to close immediately when reduced motion is preferred.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@primer/react-brand': patch
3+
'@primer/brand-css': patch
4+
---
5+
6+
Adjusted the `Card.Heading` bottom spacing from `20px` to `12px`.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@primer/react-brand': patch
3+
'@primer/brand-css': patch
4+
---
5+
6+
Adjusted the `Hero` action group top spacing from `32px` to `28px` and the expressive trailing content top spacing from `32px` to `20px` on wider viewports.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@primer/brand-primitives': patch
3+
'@primer/react-brand': patch
4+
'@primer/brand-css': patch
5+
---
6+
7+
Updated the `LogoSuite` control hover color in light mode from `gray-2` to `gray-1`.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react-brand': patch
3+
---
4+
5+
Updated the `RiverAccordion` toggle indicator to use the `TriangleDownIcon` and `TriangleUpIcon` octicons in place of chevrons, for consistency with the `Accordion` component.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@primer/react-brand': patch
3+
'@primer/brand-css': patch
4+
---
5+
6+
Updated `Tabs` item typography from text size `100` to `200`.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@primer/brand-primitives': patch
3+
'@primer/react-brand': patch
4+
'@primer/brand-css': patch
5+
---
6+
7+
Added `TextCursorAnimation` cursor color tokens. The light mode cursor color now uses `--base-color-scale-green-6`, while dark mode preserves the existing accent color.

.github/workflows/update_visual_snapshots.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ name: Update visual snapshots
22

33
env:
44
NODE_ENV: test
5+
PLAYWRIGHT_CHROME_PATH: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome # Use local Chrome instead of downaloading
56

67
on:
78
pull_request:

0 commit comments

Comments
 (0)