Add keyboard-accessible tooltip for truncated ActionList.Description#7529
Draft
liuliu-dev wants to merge 8 commits intomainfrom
Draft
Add keyboard-accessible tooltip for truncated ActionList.Description#7529liuliu-dev wants to merge 8 commits intomainfrom
liuliu-dev wants to merge 8 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 5b4e4ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
https://github.com/primer/react into liuliu/add-keyboard-accessible-tooltip-for-actionlist
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/14088 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue https://github.com/github/accessibility-audits/issues/14802
Changelog
When
ActionList.Descriptionis rendered withtruncate, the full text was only visible via a nativetitleattribute — which only appears on mouse hover, not keyboard focus (WCAG SC 2.1.1).This PR adds a Primer
<Tooltip>at theActionList.Itemlevel that shows the full description text on both hover and keyboard focus when the description is actually truncated.Rollout strategy
Testing & Reviewing
Merge checklist