Skip to content

Commit 222a846

Browse files
Fix ToggleSwitch knob spacing and border-radius to match primer/react (#4107)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 34e2446 commit 222a846

2 files changed

Lines changed: 13 additions & 6 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/view-components": patch
3+
---
4+
5+
Fix `ToggleSwitch` knob spacing and border-radius to match `primer/react`

app/components/primer/alpha/toggle_switch.pcss

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77
}
88

99
.ToggleSwitch {
10+
--toggleSwitch-knob-inset: var(--borderWidth-thin);
11+
--toggleSwitch-knob-offset: calc(2 * var(--toggleSwitch-knob-inset));
12+
1013
align-items: center;
1114
display: inline-flex;
1215
gap: var(--controlStack-medium-gap-condensed);
@@ -93,7 +96,7 @@
9396
& .ToggleSwitch-knob {
9497
background-color: var(--controlKnob-bgColor-checked);
9598
border-color: var(--controlKnob-borderColor-checked);
96-
transform: translateX(100%);
99+
transform: translateX(calc(100% - var(--toggleSwitch-knob-offset)));
97100
}
98101

99102
& .ToggleSwitch-lineIcon {
@@ -113,7 +116,6 @@
113116

114117
& .ToggleSwitch-knob {
115118
border-color: var(--borderColor-default);
116-
box-shadow: none;
117119
}
118120

119121
& .ToggleSwitch-lineIcon {
@@ -155,14 +157,14 @@
155157

156158
.ToggleSwitch-knob {
157159
position: absolute;
158-
top: 0;
159-
bottom: 0;
160+
inset-block: var(--toggleSwitch-knob-inset);
161+
inset-inline-start: var(--toggleSwitch-knob-inset);
160162
z-index: 1;
161163
width: 50%;
162164
background-color: var(--controlKnob-bgColor-rest);
163165
border: var(--borderWidth-thin) solid var(--controlKnob-borderColor-rest);
164-
border-radius: var(--borderRadius-medium);
165-
box-shadow: var(--shadow-resting-medium), var(--button-default-shadow-inset);
166+
/* stylelint-disable-next-line primer/borders */
167+
border-radius: calc(var(--borderRadius-medium) - var(--toggleSwitch-knob-offset));
166168
transition-timing-function: cubic-bezier(0.5, 1, 0.89, 1);
167169
transition-duration: 80ms;
168170
transition-property: transform;

0 commit comments

Comments
 (0)