Updates tests

Author: lindseywild

test/lib/primer/forms/text_area_input_test.rb

@@ -41,8 +41,11 @@ def test_renders_character_limit_form
     end
 
     assert_selector "primer-text-area"
-    assert_selector "textarea[name=bio]"
-    assert_selector "div.FormControl-caption--characterLimit[data-max-length='100']"
+    assert_selector "div.FormControl-caption--characterLimit[data-target='primer-text-area.characterLimitElement'][data-max-length='100']", text: "100 characters remaining."
+    assert_selector "textarea[data-target='primer-text-area.inputElement']"
+    assert_selector "span.sr-only[aria-live='polite']" do |span|
+      assert span["id"].start_with?("bio-character-count-sr-")
+    end
   end
 
   def test_character_limit
@@ -54,14 +57,9 @@ def test_character_limit
       end
     end
 
-    assert_selector "primer-text-area"
-    assert_selector "div.FormControl-caption--characterLimit[data-target='primer-text-area.characterLimitElement'][data-max-length='100']", text: "100 characters remaining."
-    assert_selector "textarea[data-target='primer-text-area.inputElement']"
 
     # Check for aria-live region
-    assert_selector "span.sr-only[aria-live='polite']" do |span|
-      assert span["id"].start_with?("bio-character-count-sr-")
-    end
+
   end
 
   def test_character_limit_rejects_zero

test/lib/primer/forms/text_field_input_test.rb

@@ -68,25 +68,9 @@ def test_renders_character_limit_form
       end
     end
 
-    assert_selector "primer-text-field"
-    assert_selector "input[name=username]"
-    assert_selector "div.FormControl-caption--characterLimit[data-max-length='20']"
-  end
-
-  def test_character_limit
-    render_in_view_context do
-      primer_form_with(url: "/foo") do |f|
-        render_inline_form(f) do |text_field_form|
-          text_field_form.text_field(name: :username, label: "Username", character_limit: 20)
-        end
-      end
-    end
-
     assert_selector "primer-text-field"
     assert_selector "div.FormControl-caption--characterLimit[data-target='primer-text-field.characterLimitElement'][data-max-length='20']", text: "20 characters remaining."
     assert_selector "input[type=text][data-target*='primer-text-field.inputElement']"
-
-    # Check for aria-live region
     assert_selector "span.sr-only[aria-live='polite']" do |span|
       assert span["id"].start_with?("username-character-count-sr-")
     end