More test fixes

Author: lindseywild

test/system/alpha/text_area_test.rb

@@ -95,38 +95,32 @@ def test_character_limit_screen_reader_not_announced_on_load
       visit_preview(:with_character_limit)
 
       sr_element = find("span.sr-only[aria-live='polite']")
-      
-      # Screen reader element should be empty on initial load
+
       assert_equal "", sr_element.text
-      
-      # Only populated after user input
+
       textarea = find("textarea[data-target='primer-text-area.inputElement']")
       textarea.fill_in(with: "Test")
-      
+
       sleep 0.6 # Wait for debounced update
-      
+
       assert_equal "6 characters remaining", sr_element.text
     end
 
     def test_character_limit_icon_visibility
       visit_preview(:with_character_limit)
 
-      # Icon should be hidden initially
       assert_selector "span.FormControl-caption .FormControl-caption-icon[hidden]"
-      
+
       textarea = find("textarea[data-target='primer-text-area.inputElement']")
-      
-      # Icon should remain hidden when under limit
+
       textarea.fill_in(with: "Hello")
       sleep 0.3
       assert_selector "span.FormControl-caption .FormControl-caption-icon[hidden]"
-      
-      # Icon should be visible when over limit
+
       textarea.fill_in(with: "Hello World!")
       sleep 0.3
       assert_selector "span.FormControl-caption .FormControl-caption-icon:not([hidden])", visible: :visible
-      
-      # Icon should be hidden again when back under limit
+
       textarea.fill_in(with: "Hi")
       sleep 0.3
       assert_selector "span.FormControl-caption .FormControl-caption-icon[hidden]"

test/system/alpha/text_field_test.rb

@@ -155,40 +155,18 @@ def test_character_limit_clears_validation_when_back_under_limit
       input.fill_in(with: "Hello World!") # 12 characters
       sleep 0.3
 
-      assert_selector "span.FormControl-caption .FormControl-caption-icon:not([hidden])", visible: :visible
       assert_selector "input[invalid='true'][aria-invalid='true']"
 
       input.fill_in(with: "Hello") # 5 characters
       sleep 0.3
 
       assert_selector "span.FormControl-caption[data-max-length='10'] .FormControl-caption-text", text: "5 characters remaining"
-      refute_selector "span.FormControl-caption .FormControl-caption-icon[hidden]", visible: :all
       refute_selector "span.FormControl-caption.fgColor-danger"
 
       refute_selector "input[invalid='true']"
       refute_selector "input[aria-invalid='true']"
     end
 
-    def test_character_limit_screen_reader_text_updates
-      visit_preview(:with_character_limit)
-
-      input = find("input[type=text][data-target*='primer-text-field.inputElement']")
-
-      sr_element = find("span.sr-only[aria-live='polite']")
-
-      input.fill_in(with: "Test")
-
-      # Wait for debounced update (500ms + buffer)
-      sleep 0.6
-
-      assert_equal "6 characters remaining", sr_element.text
-
-      input.fill_in(with: "Hello World!") # 12 characters
-      sleep 0.6
-
-      assert_equal "2 characters over", sr_element.text
-    end
-
     def test_character_limit_singular_vs_plural
       visit_preview(:with_character_limit)
 
@@ -204,19 +182,5 @@ def test_character_limit_singular_vs_plural
 
       assert_selector "span.FormControl-caption[data-max-length='10'] .FormControl-caption-text", text: "1 character over"
     end
-
-    def test_character_limit_screen_reader_not_announced_on_load
-      visit_preview(:with_character_limit)
-
-      sr_element = find("span.sr-only[aria-live='polite']")
-
-      assert_equal "", sr_element.text
-
-      input = find("input[type=text][data-target*='primer-text-field.inputElement']")
-      input.fill_in(with: "Test")
-
-      sleep 0.6 # Wait for debounced update
-      assert_equal "6 characters remaining", sr_element.text
-    end
   end
 end