test: fix func visibility and unused vars

Author: clemlak

test/TestPortfolioAllocate.t.sol

@@ -493,7 +493,7 @@ contract TestPortfolioAllocate is Setup {
         uint128 amount = 0.1 ether;
         uint64 xid = ghost().poolId;
 
-        (uint256 amount0, uint256 amount1) =
+        (uint256 amount0,) =
             subject().getLiquidityDeltas(ghost().poolId, int128(amount));
         uint256 fee0 = amount0 * 1 / 100;
         // uint256 fee1 = amount1 * 1 / 100;
@@ -749,11 +749,9 @@ contract TestPortfolioAllocate is Setup {
 
         bytes[] memory res = subject().multicall(data);
 
-        (uint256 assetDeallocate, uint256 quoteDeallocate) =
-            abi.decode(res[0], (uint256, uint256));
+        (uint256 assetDeallocate,) = abi.decode(res[0], (uint256, uint256));
 
-        (uint256 assetAllocate, uint256 quoteAllocate) =
-            abi.decode(res[1], (uint256, uint256));
+        (uint256 assetAllocate,) = abi.decode(res[1], (uint256, uint256));
 
         uint256 postAssetBalance =
             ghost().asset().to_token().balanceOf(address(actor()));

test/TestPortfolioInvariant.t.sol

@@ -69,7 +69,7 @@ contract TestPortfolioInvariant is Setup {
             inverseCdfQuotient - inverseCdfDifference + int256(volSqrtYearsWad);
     }
 
-    function test_trading_function() public {
+    function test_trading_function() public view {
         uint256 reserveXPerWad = 0.308537538726 ether;
         uint256 reserveYPerWad = 0.308537538726 ether;
         uint256 strikePriceWad = 1 ether;
@@ -89,7 +89,7 @@ contract TestPortfolioInvariant is Setup {
 
     /// Sanity check console log. Returns an invariant close to 0.
     /// The result is about 1e-7.
-    function test_invariant_initial() public {
+    function test_invariant_initial() public view {
         uint256 reserveXPerWad = 0.308537538726 ether;
         uint256 reserveYPerWad = 0.308537538726 ether;
         uint256 strikePriceWad = 1 ether;
@@ -442,7 +442,7 @@ contract TestPortfolioInvariant is Setup {
         uint256 strikePriceWad,
         uint256 volatilityWad,
         uint256 timeRemainingSec
-    ) internal returns (uint256, uint256, uint256, uint256, uint256) {
+    ) internal view returns (uint256, uint256, uint256, uint256, uint256) {
         // Need to make sure to bound the arguments to values that will be used.
         // min x + min delta <= x <= max - delta + min x - 1
         reserveXPerWad = bound(
@@ -510,7 +510,7 @@ contract TestPortfolioInvariant is Setup {
         uint256 timeRemainingSec,
         int256 previousResult,
         int256 result
-    ) internal {
+    ) internal view {
         uint256 postReserve = applyDeltaToX
             ? uint256(int256(reserveXPerWad) + delta)
             : uint256(int256(reserveYPerWad) + delta);