Skip to content

Conversation

aidankmcalister
Copy link
Member

@aidankmcalister aidankmcalister commented Sep 3, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Claim links now use a dedicated "/claim" path while preserving existing query parameters; expiry and error handling remain unchanged.
  • Chores

    • Package versions for the CLI tooling updated to 1.0.9 (no functional changes).

Copy link

coderabbitai bot commented Sep 3, 2025

Walkthrough

Claim URL construction in create-db/index.js now appends a /claim path to CLAIM_DB_WORKER_URL while preserving existing query parameters and handling. Package versions bumped from 1.0.7 to 1.0.9 in create-db, create-pg, and create-postgres. No exported/public API signatures changed.

Changes

Cohort / File(s) Summary of changes
Claim URL change
create-db/index.js
Construct claimUrl as CLAIM_DB_WORKER_URL/claim?projectID=...&utm_source=...&utm_medium=cli instead of CLAIM_DB_WORKER_URL?…; all query params, expiry, and error handling unchanged.
Package version bumps
create-db/package.json, create-pg/package.json, create-postgres/package.json
Bumped package version from 1.0.7 to 1.0.9 in each package. No other metadata or functional changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor CLI as CLI
  participant Worker as CLAIM_DB_WORKER

  rect rgba(0,128,128,0.06)
    note over CLI: Build claimUrl = CLAIM_DB_WORKER_URL + "/claim" + query params
  end

  CLI->>Worker: GET /claim?projectID=...&utm_source=...&utm_medium=cli
  alt success
    Worker-->>CLI: 200 OK + response
  else error
    Worker-->>CLI: error response (handled as before)
  end
Loading

Possibly related PRs

  • Remove replace #50 — Adjusts normalization of CLAIM_DB_WORKER_URL (trailing-slash behavior), which affects joining the new /claim path.
  • feat: --source flag added #45 — Also modifies claim URL construction (utm_source/userAgent handling), overlapping URL-related logic.
  • chore: version bump #49 — Bumps the same package versions across create-db, create-pg, and create-postgres.

Suggested reviewers

  • ankur-arch
  • mhessdev

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 34b0655 and 116b0cb.

📒 Files selected for processing (3)
  • create-db/package.json (1 hunks)
  • create-pg/package.json (1 hunks)
  • create-postgres/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Workers Builds: create-db-worker
  • GitHub Check: Workers Builds: claim-db-worker
🔇 Additional comments (3)
create-db/package.json (1)

3-3: Proceed with tagging v1.0.9 and drafting release notes
Workspace packages create-db, create-pg, and create-postgres are all at v1.0.9 and the /claim endpoint is present in create-db/index.js; please create the v1.0.9 git tag and prepare release notes.

create-pg/package.json (1)

3-3: Confirm workspace dependency and release ordering
Verified that create-pg/package.json declares "create-db": "workspace:*" under dependencies. Ensure create-db and create-pg are published in the same release to avoid registry resolution gaps.

create-postgres/package.json (1)

3-3: Coordinate publish order with create-db
create-postgres/package.json declares "create-db": "workspace:*"—publish create-db before (or co-release with) create-postgres to avoid broken installs.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claim-url-fix

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Sep 3, 2025

Preview CLIs & Workers are live!

Test the CLIs locally under tag pr53-claim-url-fix-17448257993:

npx create-db@pr53
npx create-pg@pr53
npx create-postgres@$pr53

Worker URLs
• Create-DB Worker:
• Claim-DB Worker:

These will live as long as this PR exists under tag pr53-claim-url-fix-17448257993.

Copy link

cloudflare-workers-and-pages bot commented Sep 3, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
claim-db-worker 116b0cb Commit Preview URL

Branch Preview URL
Sep 03 2025, 11:22 PM

mhessdev
mhessdev previously approved these changes Sep 3, 2025
Copy link

github-actions bot commented Sep 3, 2025

Preview CLIs & Workers are live!

Test the CLIs locally under tag pr53-claim-url-fix-17448512707:

npx create-db@pr53
npx create-pg@pr53
npx create-postgres@$pr53

Worker URLs
• Create-DB Worker:
• Claim-DB Worker:

These will live as long as this PR exists under tag pr53-claim-url-fix-17448512707.

@aidankmcalister aidankmcalister merged commit ad03c04 into main Sep 3, 2025
1 of 4 checks passed
@aidankmcalister aidankmcalister deleted the claim-url-fix branch September 3, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants