Enable expanded Biome lint rules (#86)

* enabled Biome and format

* biome recommended settings

* enable cognitive complexity lint rule

* enable no foreach lint rule

* enable no implicit coercions lint rule

* enable no conditional expect lint rule

* enable no floating promises lint rule

* enable no for in lint rule

* enable no loop func lint rule

* enable disposable lint rule

* enable no await in loops lint rule

* enable no barrel file lint rule

* enable top level regex lint rule

* enable collapsed else if lint rule

* enable collapsed if lint rule

* enable no nested ternary lint rule

* enable no parameter assign lint rule

* enable no var lint rule

* enable guarded for in lint rule

* enable static response methods lint rule

* remove empty biome rule comments

* fix mask value regex backtracking

* fix constructable test mocks

* Add PR quality workflow

* Set Node 22.12.0 as minimum version

* address biome review feedback

* trigger ci

* fix ci typecheck

Author: rtbenfield

.github/workflows/AGENTS.md

@@ -0,0 +1,3 @@
+# GitHub Workflows
+
+- Pin all GitHub Actions to their commit SHA, not a tag. Append the tag as a comment for readability (e.g., `uses: actions/checkout@abc123... # v4.3.2`).

.github/workflows/pr-quality.yml

@@ -0,0 +1,81 @@
+name: PR Quality
+
+# This workflow owns required PR status checks. Add only jobs that should block
+# merging when they fail.
+
+on:
+  pull_request:
+
+concurrency:
+  group: pr-quality-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+permissions:
+  contents: read
+
+jobs:
+  typecheck:
+    name: Type Check
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+        with:
+          persist-credentials: false
+
+      - name: Set up pnpm
+        uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
+
+      - name: Set up Node.js
+        uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
+        with:
+          node-version-file: .node-version
+          cache: pnpm
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Type check
+        run: pnpm --recursive exec tsc --noEmit
+
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+        with:
+          persist-credentials: false
+
+      - name: Set up Biome
+        uses: biomejs/setup-biome@4c91541eaada48f67d7dbd7833600ce162b68f51 # v2.7.1
+
+      - name: Lint
+        run: biome ci .
+
+  test:
+    name: Test
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+        with:
+          persist-credentials: false
+
+      - name: Set up pnpm
+        uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
+
+      - name: Set up Node.js
+        uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
+        with:
+          node-version-file: .node-version
+          cache: pnpm
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Test
+        run: pnpm --recursive test

.node-version

@@ -0,0 +1 @@
+22.12.0

biome.jsonc

@@ -0,0 +1,63 @@
+{
+  "$schema": "https://biomejs.dev/schemas/2.4.16/schema.json",
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "useIgnoreFile": true
+  },
+  "files": {
+    "ignoreUnknown": false
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 2
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "complexity": {
+        "noExcessiveCognitiveComplexity": "on",
+        "noForEach": "on",
+        "noImplicitCoercions": "on"
+      },
+      "nursery": {
+        "noConditionalExpect": "on",
+        "noFloatingPromises": "on",
+        "noForIn": "on",
+        "noLoopFunc": "on",
+        "useDisposables": "on"
+      },
+      "performance": {
+        "noAwaitInLoops": "on",
+        "noBarrelFile": "on",
+        "useTopLevelRegex": "on"
+      },
+      "style": {
+        "useCollapsedElseIf": "on",
+        "useCollapsedIf": "on",
+        "noNestedTernary": "on",
+        "noParameterAssign": "on"
+      },
+      "suspicious": {
+        "noVar": "on",
+        "useGuardForIn": "on",
+        "useStaticResponseMethods": "on"
+      }
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "double"
+    }
+  },
+  "assist": {
+    "enabled": true,
+    "actions": {
+      "source": {
+        "organizeImports": "on"
+      }
+    }
+  }
+}

examples/next-smoke/app/globals.css

@@ -21,28 +21,27 @@ body {
 
 body {
   background:
-    radial-gradient(circle at top left, rgba(42, 125, 99, 0.18), transparent 28rem),
-    radial-gradient(circle at bottom right, rgba(197, 123, 74, 0.16), transparent 30rem),
+    radial-gradient(
+      circle at top left,
+      rgba(42, 125, 99, 0.18),
+      transparent 28rem
+    ),
+    radial-gradient(
+      circle at bottom right,
+      rgba(197, 123, 74, 0.16),
+      transparent 30rem
+    ),
     var(--bg);
   color: var(--text);
   font-family:
-    "Iowan Old Style",
-    "Palatino Linotype",
-    "Book Antiqua",
-    Palatino,
-    Georgia,
+    "Iowan Old Style", "Palatino Linotype", "Book Antiqua", Palatino, Georgia,
     serif;
 }
 
 code {
   font-family:
-    "SFMono-Regular",
-    ui-monospace,
-    "Cascadia Mono",
-    "Segoe UI Mono",
-    Menlo,
-    Consolas,
-    monospace;
+    SFMono-Regular, ui-monospace, "Cascadia Mono", "Segoe UI Mono", Menlo,
+    Consolas, monospace;
   background: rgba(42, 44, 39, 0.06);
   border-radius: 0.5rem;
   padding: 0.12rem 0.4rem;

examples/next-smoke/app/page.tsx

@@ -5,7 +5,8 @@ export default function Home() {
         <p className="eyebrow">Prisma CLI</p>
         <h1>Next.js smoke app</h1>
         <p className="lede">
-          This app exists to manually test the local source Prisma CLI from inside this repository.
+          This app exists to manually test the local source Prisma CLI from
+          inside this repository.
         </p>
         <ol className="steps">
           <li>

examples/next-smoke/tsconfig.json

@@ -1,11 +1,7 @@
 {
   "compilerOptions": {
     "target": "ES2017",
-    "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
-    ],
+    "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
     "strict": true,
@@ -30,7 +26,5 @@
     ".next/types/**/*.ts",
     ".next/dev/types/**/*.ts"
   ],
-  "exclude": [
-    "node_modules"
-  ]
+  "exclude": ["node_modules"]
 }

package.json

@@ -1,10 +1,16 @@
 {
   "name": "prisma-cli",
   "private": true,
+  "engines": {
+    "node": ">=22.12.0"
+  },
   "packageManager": "pnpm@10.30.0",
   "scripts": {
     "build:cli": "pnpm --filter @prisma/cli build",
     "build:compute": "pnpm --filter @prisma/compute build",
+    "format": "biome format . --write",
+    "lint": "biome check .",
+    "lint:fix": "biome check . --write",
     "lint:skills": "node scripts/validate-skills.mjs",
     "prepare": "skills add ./skills --skill '*' --agent universal claude-code -y",
     "prepare:cli-publish": "node scripts/prepare-cli-publish.mjs",
@@ -15,6 +21,7 @@
     "prisma": "tsx packages/cli/src/bin.ts"
   },
   "devDependencies": {
+    "@biomejs/biome": "2.4.16",
     "gray-matter": "^4.0.3",
     "pkg-pr-new": "^0.0.75",
     "skills": "^1.5.9",

packages/cli/src/adapters/git.ts

@@ -1,3 +1,4 @@
+// biome-ignore-all lint/performance/useTopLevelRegex: Existing git URL parsing regexes are kept inline for readability.
 import { execFile } from "node:child_process";
 import { promisify } from "node:util";
 
@@ -11,13 +12,20 @@ export interface GitHubRepositoryReference {
   url: string;
 }
 
-export async function readGitOriginRemote(cwd: string, signal?: AbortSignal): Promise<string | null> {
+export async function readGitOriginRemote(
+  cwd: string,
+  signal?: AbortSignal,
+): Promise<string | null> {
   try {
-    const { stdout } = await execFileAsync("git", ["config", "--get", "remote.origin.url"], {
-      cwd,
-      timeout: 5_000,
-      signal,
-    });
+    const { stdout } = await execFileAsync(
+      "git",
+      ["config", "--get", "remote.origin.url"],
+      {
+        cwd,
+        timeout: 5_000,
+        signal,
+      },
+    );
     const remote = stdout.trim();
     return remote.length > 0 ? remote : null;
   } catch (error) {
@@ -30,9 +38,13 @@ function isAbortError(error: unknown): boolean {
   return error instanceof Error && error.name === "AbortError";
 }
 
-export function parseGitHubRepositoryUrl(value: string): GitHubRepositoryReference | null {
+export function parseGitHubRepositoryUrl(
+  value: string,
+): GitHubRepositoryReference | null {
   const input = value.trim();
-  const shorthand = input.match(/^git@github\.com:([^/\s]+)\/([^/\s]+?)(?:\.git)?$/);
+  const shorthand = input.match(
+    /^git@github\.com:([^/\s]+)\/([^/\s]+?)(?:\.git)?$/,
+  );
 
   if (shorthand) {
     return toGitHubRepositoryReference(shorthand[1], shorthand[2]);
@@ -49,7 +61,11 @@ export function parseGitHubRepositoryUrl(value: string): GitHubRepositoryReferen
     return null;
   }
 
-  if (parsed.protocol !== "https:" && parsed.protocol !== "http:" && parsed.protocol !== "ssh:") {
+  if (
+    parsed.protocol !== "https:" &&
+    parsed.protocol !== "http:" &&
+    parsed.protocol !== "ssh:"
+  ) {
     return null;
   }
 
@@ -64,7 +80,10 @@ export function parseGitHubRepositoryUrl(value: string): GitHubRepositoryReferen
   return toGitHubRepositoryReference(owner, name);
 }
 
-function toGitHubRepositoryReference(owner: string | undefined, name: string | undefined): GitHubRepositoryReference | null {
+function toGitHubRepositoryReference(
+  owner: string | undefined,
+  name: string | undefined,
+): GitHubRepositoryReference | null {
   if (!owner || !name || owner.includes("/") || name.includes("/")) {
     return null;
   }