Document pre-commit verification

Author: rtbenfield

AGENTS.md

@@ -15,3 +15,12 @@ Use this file for repo-wide instructions. Use package-local `AGENTS.md` files fo
 
 - Use `pnpm` for commands run inside this repo.
 - Use `npm` or multiple package-manager examples in user-facing content.
+
+## Pre-Commit Verification
+
+- `pnpm --recursive exec tsc --noEmit`
+- `pnpm lint`
+- Package-specific tests for changed packages
+  - `pnpm --filter @prisma/cli test`
+  - `pnpm --filter @prisma/compute test`
+- If verification fails because work is intentionally incomplete, include the failing command and reason in the commit message.

packages/cli/tests/resolve-package-version.test.ts

@@ -20,18 +20,24 @@ const scriptPath = path.join(repoRoot, "scripts/resolve-package-version.mjs");
 
 describe("resolve package version", () => {
   it("computes the first beta when npm latest is missing or still legacy 2.x", () => {
-    expect(resolveNextBetaVersion({ baseVersion: "3.0.0", latest: "" })).toBe("3.0.0-beta.0");
-    expect(resolveNextBetaVersion({ baseVersion: "3.0.0", latest: "2.20.1" })).toBe("3.0.0-beta.0");
+    expect(resolveNextBetaVersion({ baseVersion: "3.0.0", latest: "" })).toBe(
+      "3.0.0-beta.0",
+    );
+    expect(
+      resolveNextBetaVersion({ baseVersion: "3.0.0", latest: "2.20.1" }),
+    ).toBe("3.0.0-beta.0");
   });
 
   it("increments the beta number from the current npm latest", () => {
-    expect(resolveNextBetaVersion({ baseVersion: "3.0.0", latest: "3.0.0-beta.0" })).toBe("3.0.0-beta.1");
+    expect(
+      resolveNextBetaVersion({ baseVersion: "3.0.0", latest: "3.0.0-beta.0" }),
+    ).toBe("3.0.0-beta.1");
   });
 
   it("fails when npm latest is outside the supported beta line", () => {
-    expect(() => resolveNextBetaVersion({ baseVersion: "3.0.0", latest: "3.0.0" })).toThrow(
-      "Cannot compute the next beta from npm latest (3.0.0).",
-    );
+    expect(() =>
+      resolveNextBetaVersion({ baseVersion: "3.0.0", latest: "3.0.0" }),
+    ).toThrow("Cannot compute the next beta from npm latest (3.0.0).");
   });
 
   it("computes a unique dev build version", () => {

scripts/resolve-package-version.d.mts

@@ -15,4 +15,6 @@ export declare function resolveNextBetaVersion(options: {
   latest?: string | null;
 }): string;
 
-export declare function resolvePackageReleaseBaseVersion(packageDir: string): string;
+export declare function resolvePackageReleaseBaseVersion(
+  packageDir: string,
+): string;

scripts/resolve-package-version.mjs

@@ -1,9 +1,12 @@
 #!/usr/bin/env node
 
-import path from "node:path";
 import { readFileSync } from "node:fs";
+import path from "node:path";
 import { fileURLToPath } from "node:url";
 
+const PACKAGE_VERSION_PATTERN = /^(\d+\.\d+\.\d+)(?:-.+)?$/;
+const VERSION_CORE_PATTERN = /^(\d+)\.(\d+)\.(\d+)(?:-.+)?$/;
+
 export function resolveDevVersion(options) {
   const baseVersion = requireValue(options.baseVersion, "baseVersion");
   const runNumber = requireValue(options.runNumber, "runNumber");
@@ -29,7 +32,9 @@ export function resolveNextBetaVersion(options) {
     return `${baseVersion}-beta.0`;
   }
 
-  const betaMatch = normalizedLatest.match(new RegExp(`^${escapeRegExp(baseVersion)}-beta\\.(\\d+)$`));
+  const betaMatch = normalizedLatest.match(
+    new RegExp(`^${escapeRegExp(baseVersion)}-beta\\.(\\d+)$`),
+  );
   if (betaMatch) {
     const nextNumber = Number(betaMatch[1]) + 1;
     return `${baseVersion}-beta.${nextNumber}`;
@@ -43,11 +48,16 @@ export function resolveNextBetaVersion(options) {
 export function resolvePackageReleaseBaseVersion(packageDir) {
   const manifestPath = path.join(getRepoRoot(), packageDir, "package.json");
   const manifest = JSON.parse(readFileSync(manifestPath, "utf8"));
-  const version = requireValue(manifest.version, `${packageDir} package.json version`);
-  const match = version.match(/^(\d+\.\d+\.\d+)(?:-.+)?$/);
+  const version = requireValue(
+    manifest.version,
+    `${packageDir} package.json version`,
+  );
+  const match = version.match(PACKAGE_VERSION_PATTERN);
 
   if (!match) {
-    throw new Error(`Cannot derive release base from ${packageDir} package version (${version}).`);
+    throw new Error(
+      `Cannot derive release base from ${packageDir} package version (${version}).`,
+    );
   }
 
   return match[1];
@@ -79,7 +89,7 @@ function isOlderReleaseLine(latest, baseVersion) {
 }
 
 function parseVersionCore(version) {
-  const match = version.match(/^(\d+)\.(\d+)\.(\d+)(?:-.+)?$/);
+  const match = version.match(VERSION_CORE_PATTERN);
 
   if (!match) {
     return undefined;
@@ -139,34 +149,45 @@ function main() {
   const baseVersion = resolvePackageReleaseBaseVersion(packageDir);
 
   if (command === "dev") {
-    process.stdout.write(`version=${resolveDevVersion({
-      baseVersion,
-      runNumber: options["run-number"],
-      runAttempt: options["run-attempt"],
-    })}\n`);
+    process.stdout.write(
+      `version=${resolveDevVersion({
+        baseVersion,
+        runNumber: options["run-number"],
+        runAttempt: options["run-attempt"],
+      })}\n`,
+    );
     return;
   }
 
   if (command === "pr") {
-    process.stdout.write(`version=${resolvePrVersion({
-      baseVersion,
-      prNumber: options["pr-number"],
-      sha: options.sha,
-    })}\n`);
+    process.stdout.write(
+      `version=${resolvePrVersion({
+        baseVersion,
+        prNumber: options["pr-number"],
+        sha: options.sha,
+      })}\n`,
+    );
     return;
   }
 
   if (command === "next-beta") {
     const latest = options.latest ?? "";
     process.stdout.write(`latest=${latest}\n`);
-    process.stdout.write(`version=${resolveNextBetaVersion({ baseVersion, latest })}\n`);
+    process.stdout.write(
+      `version=${resolveNextBetaVersion({ baseVersion, latest })}\n`,
+    );
     return;
   }
 
-  throw new Error("Usage: resolve-package-version.mjs <dev|pr|next-beta> [--package-dir <path>] [options]");
+  throw new Error(
+    "Usage: resolve-package-version.mjs <dev|pr|next-beta> [--package-dir <path>] [options]",
+  );
 }
 
-if (process.argv[1] && fileURLToPath(import.meta.url) === path.resolve(process.argv[1])) {
+if (
+  process.argv[1] &&
+  fileURLToPath(import.meta.url) === path.resolve(process.argv[1])
+) {
   try {
     main();
   } catch (error) {