prevent shorthand filters from being misclassified as AST nodes

wmadden · wmadden · commit 0f923aac415d · 2026-03-26T14:53:16.000+01:00
Add accept-method check alongside kind discriminant in isWhereDirectInput
so plain objects with a matching kind value (e.g. { kind: 'binary' }) go
through shorthandToWhereExpr instead of being treated as prebuilt ASTs.
diff --git a/packages/3-extensions/sql-orm-client/src/collection.ts b/packages/3-extensions/sql-orm-client/src/collection.ts
@@ -105,7 +105,10 @@ function isToWhereExprInput(value: unknown): value is ToWhereExpr {
 }
 
 function isWhereDirectInput(value: unknown): value is WhereDirectInput {
-  return isWhereExpr(value) || isToWhereExprInput(value);
+  return (
+    (isWhereExpr(value) && typeof (value as { accept?: unknown }).accept === 'function') ||
+    isToWhereExprInput(value)
+  );
 }
 
 export class Collection<

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,10 @@ function isToWhereExprInput(value: unknown): value is ToWhereExpr {`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`function isWhereDirectInput(value: unknown): value is WhereDirectInput {`
`108`		`- return isWhereExpr(value) \|\| isToWhereExprInput(value);`
	`108`	`+ return (`
	`109`	`+ (isWhereExpr(value) && typeof (value as { accept?: unknown }).accept === 'function') \|\|`
	`110`	`+ isToWhereExprInput(value)`
	`111`	`+ );`
`109`	`112`	`}`
`110`	`113`
`111`	`114`	`export class Collection<`