Commit d969acd
chore: close out migration-graph-rendering project (TML-2746) (#775)
## Close-out: migration-graph-rendering
Closes the `migration-graph-rendering` project (TML-2746). It began as a
redesign of `migration graph`'s renderer and broadened into a revamp of
the whole interrogative migration **read-command family** (`list` /
`graph` / `status` / `log`) on a shared renderer + ledger foundation.
All work has shipped; this PR migrates the durable knowledge into
`docs/` and deletes the transient project scaffolding.
### Definition of Done — verified
| Outcome | Evidence |
|---|---|
| Tier-3 renderer rebuilt (line/plane/occlusion) | #762 |
| Back-arc convergence, configurable geometry, greedy lane colouring,
layout fixes | #767 |
| Ledger foundation (per-migration journal) | #665 |
| `list`/`status`/`log` revamped on the shared renderer; dagre + `list
--graph` retired | shipped; verified —
`migration-list/status/log/graph.ts` use the shared renderer; no
`dagre`/`tree-render`/`layout` renderers remain |
| Read-command consistency (TML-2801) | re-validated this PR: 4/7
findings resolved, 2 partial, 1 open (4 small follow-ups noted below) |
| Showcase real-world golden | on `main` |
No unmet acceptance criteria. External-reference scan for
`projects/migration-graph-rendering/` is empty (reference-strip step was
a no-op).
### Durable knowledge migrated to `docs/`
- **ADR 227** — Migration read commands share one graphical renderer
with command-specific annotations.
- **ADR 228** — The migration apply ledger is a per-migration journal.
- **ADR 229** — The migration graph renderer uses a line/plane/occlusion
model (the renderer's internal design — lines as the primitive,
single-owner cells, occlusion over blended glyphs). All three verified
against shipped code.
- **`docs/reference/Migration Graph Visual Language.md`** — the
glyph/layout vocabulary the renderer draws from (was the project's
`mockups.md`).
The read-command consistency audit was **re-validated** against current
code (verdict: largely accomplished — 4/7 findings resolved, 2 partial,
1 open) and captured as a Linear follow-up ticket (**TML-2877**, related
to TML-2801) rather than a committed doc, since what remains is
actionable backlog, not long-lived reference.
Transient artefacts (spec, plan, slice specs/plans/reviews,
`decisions.md` — now ADR'd, `learnings.md`, the followups draft,
`trace.jsonl`, prototype, the audit doc) deleted with the folder / moved
to Linear.
### Follow-ups (tracked, not in this PR)
- **TML-2877** — the four remaining read-command consistency items (show
`--space` policy, log unscoped-semantics doc, check see-also, show/check
decoration flags, + a parity-test extension).
- **PR #773** — the demo fixture no-op self-edge fix + offline integrity
guard.
### Retro — lessons
- **A wholesale rewrite obsoletes fine-grained bug-slices.** Three
glyph-bug slice specs (tee/marker bugs) were made moot by the
line/plane/occlusion rewrite — they targeted deleted code. Re-triage the
backlog after a rewrite; don't carry dead slices.
- **Hand-authored goldens beat auto-snapshots for correctness.**
`toMatchSnapshot()` self-certifies whatever the renderer emits; the
hand-authored `golden-pipeline` oracle caught a convergence regression
the snapshots happily recorded as "correct."
- **Real-world fixtures expose layout bugs unit fixtures miss.**
Validating against the `showcase` graph surfaced four distinct
layout/colour bugs (disconnected-component interleave,
asymmetric-diamond merge lane, trunk-continuation, greedy-colour
wraparound) that the simple scenarios never hit.
- **`@prisma-next/cli` runs vitest with `isolate: false`** — "passes
locally" ≠ passes in CI (parallel state pollution). Candidate for a
durable testing note.
- **`fixtures:emit` can emit an integrity-failing fixture** — the
emitter and `migration check` disagreed (a hash-collapse produced a
no-op self-edge). Landed an offline demo integrity guard (#773).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Signed-off-by: Will Madden <madden@prisma.io>
Co-authored-by: Will Madden <madden@prisma.io>1 parent ec5f7df commit d969acd
48 files changed
Lines changed: 402 additions & 4853 deletions
File tree
- docs
- architecture docs
- adrs
- reference
- projects/migration-graph-rendering
- design
- prototype
- slices
- check-single-target-multi-space
- edges-on-plan
- empty-origin-as-null
- ledger-foundation
- list-renders-tree
- log-reads-ledger
- migrate-show-preview
- migration-fixture-audit
- migration-graph-space-flag
- read-command-consistency
- read-command-json-redesign
- reconcile-control-api-surface
- remove-list-graph-renderer
- render-polish-and-ledger-tests
- render-redesign-core
- render-redesign-geometry
- status-db-overlay
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
92 | 95 | | |
93 | 96 | | |
94 | 97 | | |
| |||
Lines changed: 137 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
0 commit comments