Skip to content

Commit 0dd35e8

Browse files
fix(ui): keep readable text contrast on Discard edits hover
The "Discard edits" button used `variant="outline"`, which injects `hover:text-accent-foreground`. The local className overrode the hover background (`hover:bg-amber-200`) but not the hover text color, so on hover the text turned the light accent-foreground color over an amber background, producing poor contrast. Drop `variant="outline"` (default variant has no hover text-color rule) and add `border` to the className. This matches the sibling "Save edits" button's pattern. Text now stays `text-amber-950` in both default and hover states.
1 parent 1a3731f commit 0dd35e8

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

ui/studio/views/table/ActiveTableView.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,9 +1695,8 @@ export function ActiveTableView(_props: ViewProps) {
16951695
? `${discardWiggleAnimationKey}-${discardWiggleCount}`
16961696
: undefined
16971697
}
1698-
variant="outline"
16991698
className={cn(
1700-
"h-9 border-amber-300 bg-amber-100 px-4 font-sans text-amber-950 hover:border-amber-400 hover:bg-amber-200 motion-safe:origin-center motion-safe:will-change-transform",
1699+
"h-9 border border-amber-300 bg-amber-100 px-4 font-sans text-amber-950 hover:border-amber-400 hover:bg-amber-200 motion-safe:origin-center motion-safe:will-change-transform",
17011700
discardWiggleAnimationClassName,
17021701
)}
17031702
onClick={() => setDiscardDialogOpen(true)}

0 commit comments

Comments
 (0)