Log system queries to query insights stream

Author: sorenbs

Architecture/query-insights.md

@@ -73,7 +73,7 @@ Selecting a row auto-pauses table updates. Closing a sheet that caused auto-paus
 
 Studio's `Query` contract includes `meta.visibility`.
 
-Postgres adapter-generated introspection, table reads, mutations, and fallback lint helper queries MUST be marked `studio-system`. Raw SQL editor executions remain user-visible. BFF hosts should append `-- prisma:studio` to system queries before forwarding them to the database so backend Query Insights implementations can filter them consistently with `-- prisma:console`.
+Postgres adapter-generated introspection, table reads, mutations, and fallback lint helper queries MUST be marked `studio-system`. Raw SQL editor executions remain user-visible. BFF hosts should append `-- prisma:studio` to system queries before forwarding them to the database so backend Query Insights implementations can classify them consistently with `-- prisma:console`. System classification MUST NOT prevent successful query executions from being appended to `prisma-log`.
 
 ## ppg-dev Demo
 
@@ -82,7 +82,7 @@ The local `ppg-dev` demo hosts the Query Insights backend itself:
 - `/api/config` advertises the Query Insights transport URLs
 - ppg-dev ensures the `prisma-log` stream exists on the configured Prisma
   Streams server at startup
-- `/api/query` appends the Studio system suffix to system queries, executes the database request, and appends each successful user-visible SQL execution to `prisma-log`
+- `/api/query` appends the Studio system suffix to system queries, executes the database request, and appends each successful SQL execution to `prisma-log` with query visibility metadata
 - the Query Insights UI reads from `/api/streams/v1/stream/prisma-log`, so it
   uses the same same-origin Streams proxy as the Stream view
 - `/api/query-insights/analyze` returns deterministic demo analysis

FEATURES.md

@@ -26,7 +26,7 @@ In that mode the shell hides schema selection, table navigation, and database-on
 Embedders can provide a Query Insights transport that adds a native Studio view at `view=query-insights`.
 The view reads query events from a `prisma-log` Prisma Streams stream while active, buckets event timestamps into latency and queries-per-second charts, groups Prisma operations when metadata is available, and keeps the query table sortable, filterable by table, and bounded in memory.
 Selecting a row opens a Studio sheet with SQL, runtime stats, Prisma operation context, and structured recommendations after workspace-scoped AI consent.
-The `ppg-dev` demo appends user-originated SQL from `/api/query` into `prisma-log` continuously through the same Streams server used by the demo, while hiding Studio system queries.
+The `ppg-dev` demo appends every successful SQL execution from `/api/query` into `prisma-log` continuously through the same Streams server used by the demo, with Studio system queries annotated for downstream classification.
 
 ## Local Streams Development Override
 

demo/ppg-dev/query-insights.test.ts

@@ -4,6 +4,7 @@ import {
   analyzeDemoQueryInsight,
   appendStudioSystemQuerySuffix,
   createQueryInsightsLogEvent,
+  getQueryInsightsQueryVisibility,
   isStudioSystemQuery,
   parseSqlTableNames,
   QUERY_INSIGHTS_LOG_STREAM_NAME,
@@ -22,6 +23,7 @@ describe("ppg-dev Query Insights helpers", () => {
       `select * from pg_catalog.pg_class ${STUDIO_SYSTEM_QUERY_SUFFIX}`,
     );
     expect(isStudioSystemQuery(tagged)).toBe(true);
+    expect(getQueryInsightsQueryVisibility(tagged)).toBe("studio-system");
     expect(
       isStudioSystemQuery({
         meta: { visibility: "user" },
@@ -43,7 +45,7 @@ describe("ppg-dev Query Insights helpers", () => {
     expect(parseSqlTableNames("select * from pg_catalog.pg_class")).toEqual([]);
   });
 
-  it("builds prisma-log query events and skips Studio system queries", () => {
+  it("builds prisma-log query events for user and Studio system queries", () => {
     const event = createQueryInsightsLogEvent({
       durationMs: 12.5,
       query: {
@@ -63,14 +65,30 @@ describe("ppg-dev Query Insights helpers", () => {
       tables: ["organizations"],
       ts: 1_700_000_000_000,
       type: "query",
+      visibility: "user",
+    });
+    const systemEvent = createQueryInsightsLogEvent({
+      durationMs: 1,
+      query: appendStudioSystemQuerySuffix({
+        meta: { visibility: "studio-system" },
+        parameters: [],
+        sql: "select * from pg_catalog.pg_class",
+      }),
+      rows: [],
+      ts: 1_700_000_000_001,
+    });
+
+    expect(systemEvent).toMatchObject({
+      sql: "select * from pg_catalog.pg_class",
+      type: "query",
+      visibility: "studio-system",
     });
     expect(
       createQueryInsightsLogEvent({
         durationMs: 1,
         query: {
-          meta: { visibility: "studio-system" },
           parameters: [],
-          sql: "select * from pg_catalog.pg_class",
+          sql: "   ",
         },
         rows: [],
       }),

demo/ppg-dev/query-insights.ts

@@ -2,6 +2,7 @@ import type { Query } from "../../data/query";
 import type {
   QueryInsightsAnalysisResult,
   QueryInsightsAnalyzeInput,
+  QueryInsightsQueryVisibility,
   QueryInsightsStreamQuery,
 } from "../../ui/studio/views/query-insights/types";
 
@@ -11,6 +12,7 @@ const CONSOLE_SYSTEM_QUERY_SUFFIX = "-- prisma:console";
 
 export interface QueryInsightsLogEvent extends QueryInsightsStreamQuery {
   type: "query";
+  visibility: QueryInsightsQueryVisibility;
 }
 
 function normalizeSql(sql: string): string {
@@ -32,6 +34,12 @@ export function isStudioSystemQuery(query: Query<unknown>): boolean {
   );
 }
 
+export function getQueryInsightsQueryVisibility(
+  query: Query<unknown>,
+): QueryInsightsQueryVisibility {
+  return isStudioSystemQuery(query) ? "studio-system" : "user";
+}
+
 export function appendStudioSystemQuerySuffix<T>(query: Query<T>): Query<T> {
   if (query.meta?.visibility !== "studio-system") {
     return query;
@@ -76,10 +84,6 @@ export function createQueryInsightsLogEvent(args: {
   rows: unknown;
   ts?: number;
 }): QueryInsightsLogEvent | null {
-  if (isStudioSystemQuery(args.query)) {
-    return null;
-  }
-
   const cleanedSql = stripKnownSystemSuffixes(args.query.sql);
   const normalizedSql = normalizeSql(cleanedSql);
 
@@ -103,6 +107,7 @@ export function createQueryInsightsLogEvent(args: {
     tables: parseSqlTableNames(cleanedSql),
     ts: args.ts ?? Date.now(),
     type: "query",
+    visibility: getQueryInsightsQueryVisibility(args.query),
   };
 }
 

ui/studio/views/query-insights/codecs.test.ts

@@ -29,6 +29,7 @@ describe("Query Insights stream codecs", () => {
           sql: "select id from users",
           tables: ["users"],
           ts: 1_700_000_000_000,
+          visibility: "user",
         },
       ]),
     );
@@ -48,6 +49,7 @@ describe("Query Insights stream codecs", () => {
         model: "User",
       },
       queryId: "query-1",
+      visibility: "user",
     });
     expect(chartTick).toEqual({
       data: {
@@ -85,6 +87,7 @@ describe("Query Insights stream codecs", () => {
           tables: ["organizations"],
           ts: 1_700_000_000_100,
           type: "query",
+          visibility: "studio-system",
         },
         {
           count: 2,
@@ -124,6 +127,7 @@ describe("Query Insights stream codecs", () => {
 
     expect(decoded.success).toBe(true);
     expect(decoded.data).toHaveLength(3);
+    expect(decoded.data?.[0]?.visibility).toBe("studio-system");
     expect(createChartTicksFromQueries(decoded.data ?? [])).toEqual([
       {
         avgDurationMs: 40 / 3,

ui/studio/views/query-insights/codecs.ts

@@ -2,6 +2,7 @@ import {
   QUERY_INSIGHTS_CHART_BUCKET_MS,
   type QueryInsightsChartPoint,
   type QueryInsightsPrismaInfo,
+  type QueryInsightsQueryVisibility,
   type QueryInsightsStreamQuery,
 } from "./types";
 
@@ -101,6 +102,22 @@ function decodeOptionalString(value: unknown): string | null | undefined {
   return assertString(value, "optional string field");
 }
 
+function decodeOptionalVisibility(
+  value: unknown,
+): QueryInsightsQueryVisibility | undefined {
+  if (value === undefined) {
+    return undefined;
+  }
+
+  if (value === "studio-system" || value === "user") {
+    return value;
+  }
+
+  throw new Error(
+    "Invalid Query Insights event: visibility must be studio-system or user.",
+  );
+}
+
 function decodeStreamQuery(value: unknown): QueryInsightsStreamQuery {
   if (!isRecord(value)) {
     throw new Error(
@@ -138,6 +155,7 @@ function decodeStreamQuery(value: unknown): QueryInsightsStreamQuery {
     sql,
     tables: assertStringArray(value.tables, "tables"),
     ts,
+    visibility: decodeOptionalVisibility(value.visibility),
   };
 }
 

ui/studio/views/query-insights/rows.test.ts

@@ -64,6 +64,7 @@ describe("Query Insights row helpers", () => {
       duration: 84.2,
       reads: 12,
       rowsReturned: 2,
+      visibility: undefined,
     });
   });
 

ui/studio/views/query-insights/rows.ts

@@ -34,6 +34,7 @@ export function toQueryInsight(
     reads: query.reads,
     rowsReturned: query.rowsReturned,
     tables: query.tables,
+    visibility: query.visibility,
   };
 }
 
@@ -73,6 +74,7 @@ function mergeQueryInsight(
     reads: existing.reads + incoming.reads,
     rowsReturned: existing.rowsReturned + incoming.rowsReturned,
     tables: Array.from(tables).sort(),
+    visibility: incoming.visibility ?? existing.visibility,
   };
 }
 

ui/studio/views/query-insights/types.ts

@@ -10,6 +10,8 @@ export interface QueryInsightsPrismaInfo {
   payload?: Record<string, unknown> | Array<Record<string, unknown>>;
 }
 
+export type QueryInsightsQueryVisibility = "studio-system" | "user";
+
 export interface QueryInsightsQuery {
   count: number;
   duration: number;
@@ -24,6 +26,7 @@ export interface QueryInsightsQuery {
   reads: number;
   rowsReturned: number;
   tables: string[];
+  visibility?: QueryInsightsQueryVisibility;
 }
 
 export interface QueryInsightsStreamQuery {
@@ -39,6 +42,7 @@ export interface QueryInsightsStreamQuery {
   sql: string;
   tables: string[];
   ts: number;
+  visibility?: QueryInsightsQueryVisibility;
 }
 
 export interface QueryInsightsChartPoint {