test: remove automatic logout for all tests

Author: xrutayisire

playwright/fixtures/index.ts

@@ -1,6 +1,3 @@
-import * as fs from "fs/promises";
-import * as os from "os";
-import * as path from "path";
 import { test as baseTest, expect } from "@playwright/test";
 import { SharedSlice } from "@prismicio/types-internal/lib/customtypes";
 import {
@@ -48,10 +45,10 @@ type Fixtures = {
   /**
    * Data
    */
-  reusablePageType: { name: string };
-  singlePageType: { name: string };
-  reusableCustomType: { name: string };
-  singleCustomType: { name: string };
+  reusablePageType: { name: string; id: string };
+  singlePageType: { name: string; id: string };
+  reusableCustomType: { name: string; id: string };
+  singleCustomType: { name: string; id: string };
   slice: { name: string };
   repeatableZoneSlice: { name: string };
   firstSliceLibrary: { id: string };
@@ -116,49 +113,69 @@ export const test = baseTest.extend<Options & Fixtures>({
     await pageTypesTablePage.goto();
     await pageTypesTablePage.openCreateDialog();
 
-    const pageTypeName = "Page Type " + generateRandomId();
+    const uuid = generateRandomId();
+    const pageTypeName = "Page Type " + uuid;
     await pageTypesTablePage.createTypeDialog.createType(
       pageTypeName,
       "reusable",
     );
 
-    await use({ name: pageTypeName });
+    await use({ name: pageTypeName, id: `page_type_${uuid}` });
+
+    await pageTypesTablePage.goto();
+    await pageTypesTablePage.openActionMenu(pageTypeName, "Remove");
+    await pageTypesTablePage.deleteTypeDialog.deleteType();
   },
   singlePageType: async ({ pageTypesTablePage }, use) => {
     await pageTypesTablePage.goto();
     await pageTypesTablePage.openCreateDialog();
 
-    const pageTypeName = "Page Type " + generateRandomId();
+    const uuid = generateRandomId();
+    const pageTypeName = "Page Type " + uuid;
     await pageTypesTablePage.createTypeDialog.createType(
       pageTypeName,
       "single",
     );
 
-    await use({ name: pageTypeName });
+    await use({ name: pageTypeName, id: `page_type_${uuid}` });
+
+    await pageTypesTablePage.goto();
+    await pageTypesTablePage.openActionMenu(pageTypeName, "Remove");
+    await pageTypesTablePage.deleteTypeDialog.deleteType();
   },
   reusableCustomType: async ({ customTypesTablePage }, use) => {
     await customTypesTablePage.goto();
     await customTypesTablePage.openCreateDialog();
 
-    const customTypeName = "Custom Type " + generateRandomId();
+    const uuid = generateRandomId();
+    const customTypeName = "Custom Type " + uuid;
     await customTypesTablePage.createTypeDialog.createType(
       customTypeName,
       "reusable",
     );
 
-    await use({ name: customTypeName });
+    await use({ name: customTypeName, id: `custom_type_${uuid}` });
+
+    await customTypesTablePage.goto();
+    await customTypesTablePage.openActionMenu(customTypeName, "Remove");
+    await customTypesTablePage.deleteTypeDialog.deleteType();
   },
   singleCustomType: async ({ customTypesTablePage }, use) => {
     await customTypesTablePage.goto();
     await customTypesTablePage.openCreateDialog();
 
-    const customTypeName = "Custom Type " + generateRandomId();
+    const uuid = generateRandomId();
+    const customTypeName = "Custom Type " + uuid;
     await customTypesTablePage.createTypeDialog.createType(
       customTypeName,
       "single",
     );
 
-    await use({ name: customTypeName });
+    await use({ name: customTypeName, id: `custom_type_${uuid}` });
+
+    await customTypesTablePage.goto();
+    await customTypesTablePage.openActionMenu(customTypeName, "Remove");
+    await customTypesTablePage.deleteTypeDialog.deleteType();
   },
   slice: async ({ slicesListPage }, use) => {
     await slicesListPage.goto();
@@ -170,6 +187,10 @@ export const test = baseTest.extend<Options & Fixtures>({
     await slicesListPage.createSliceDialog.createSlice(sliceName);
 
     await use({ name: sliceName });
+
+    await slicesListPage.goto();
+    await slicesListPage.openActionMenu(sliceName, "Delete");
+    await slicesListPage.deleteSliceDialog.deleteSlice(sliceName);
   },
   repeatableZoneSlice: async ({ firstSliceLibrary, manager }, use) => {
     const sliceName = "Slice" + generateRandomId();
@@ -196,6 +217,11 @@ export const test = baseTest.extend<Options & Fixtures>({
     });
 
     await use({ name: model.name });
+
+    await manager.slices.deleteSlice({
+      libraryID: firstSliceLibrary.id,
+      sliceID: model.id,
+    });
   },
   firstSliceLibrary: async ({ manager }, use) => {
     const config = await manager.project.getSliceMachineConfig();
@@ -280,13 +306,6 @@ export const test = baseTest.extend<Options & Fixtures>({
     const newContext = await browser.newContext({ storageState });
     const page = await newContext.newPage();
 
-    // Logout user by default
-    try {
-      await fs.rm(path.join(os.homedir(), ".prismic"));
-    } catch (error) {
-      // Ignore since it means the user is already logged out
-    }
-
     // Propagate the modified page to the test
     await use(page);
 

playwright/pages/ChangesPage.ts

@@ -12,6 +12,7 @@ export class ChangesPage extends SliceMachinePage {
   readonly notLoggedInTitle: Locator;
   readonly notAuthorizedTitle: Locator;
   readonly blankSlateTitle: Locator;
+  readonly postPushBlankSlateTitle: Locator;
   readonly unknownErrorMessage: Locator;
   readonly softLimitTitle: Locator;
   readonly softLimitCheckbox: Locator;
@@ -50,6 +51,10 @@ export class ChangesPage extends SliceMachinePage {
     this.blankSlateTitle = page.getByText("Everything is up-to-date", {
       exact: true,
     });
+    this.postPushBlankSlateTitle = page.getByText(
+      "Success! Your changes have been pushed to the Page Builder.",
+      { exact: true },
+    );
     this.unknownErrorMessage = page.getByText(
       "Something went wrong when pushing your changes. Check your terminal logs.",
       {
@@ -100,6 +105,7 @@ export class ChangesPage extends SliceMachinePage {
     await this.pushChangesButton.click();
     await expect(this.pushChangesButton).toBeDisabled();
     await this.checkPushedMessage();
+    await expect(this.postPushBlankSlateTitle).toBeVisible();
   }
 
   async confirmDeleteDocuments() {
@@ -136,6 +142,18 @@ export class ChangesPage extends SliceMachinePage {
     ).toBeVisible();
   }
 
+  async checkSliceName(name: string) {
+    await expect(
+      this.getSliceCard(name).getByText(name, { exact: true }),
+    ).toBeVisible();
+  }
+
+  async checkSliceStatus(name: string, status: string) {
+    await expect(
+      this.getSliceCard(name).getByText(status, { exact: true }),
+    ).toBeVisible();
+  }
+
   async checkPushedMessage() {
     await expect(this.pushedMessaged).toBeVisible();
     await expect(this.pushedMessaged).not.toBeVisible();

playwright/playwright.config.ts

@@ -108,9 +108,7 @@ const config = {
   // Run local dev servers before starting the tests if needed.
   webServer: {
     cwd: "..",
-    command: process.env["CI"]
-      ? `yarn play --prefix ${REPOSITORY_NAME_PREFIX}`
-      : `yarn play`,
+    command: "yarn play",
     url: "http://localhost:9999/",
     reuseExistingServer: !process.env["CI"],
     stdout: "pipe",

playwright/tests/changes/changes.spec.ts

@@ -1,20 +1,11 @@
-import { CustomType } from "@prismicio/types-internal/lib/customtypes";
 import { expect } from "@playwright/test";
 
 import { test } from "../../fixtures";
 import { generateLibraries, generateTypes } from "../../mocks";
 
 test("I cannot see the login screen when logged in", async ({
   changesPage,
-  procedures,
 }) => {
-  procedures.mock("getState", ({ data }) => ({
-    ...(data as Record<string, unknown>),
-    clientError: {
-      clientError: undefined,
-    },
-  }));
-
   await changesPage.goto();
   await expect(changesPage.loginButton).not.toBeVisible();
   await expect(changesPage.notLoggedInTitle).not.toBeVisible();
@@ -73,27 +64,23 @@ test("I can see the empty state when I don't have any changes to push", async ({
 
 test("I can see the changes I have to push", async ({
   changesPage,
-  procedures,
+  reusablePageType,
+  slice,
 }) => {
-  const types = generateTypes({ typesCount: 1 });
-  const customType = types[0] as CustomType;
-  procedures.mock("getState", ({ data }) => ({
-    ...(data as Record<string, unknown>),
-    libraries: generateLibraries({ slicesCount: 0 }),
-    customTypes: types,
-    remoteCustomTypes: [],
-    remoteSlices: [],
-    clientError: undefined,
-  }));
-
   await changesPage.goto();
   await expect(changesPage.loginButton).not.toBeVisible();
+
+  // Custom Type
   await changesPage.checkCustomTypeName(
-    customType.id,
-    customType.label as string,
+    reusablePageType.id,
+    reusablePageType.name,
   );
-  await changesPage.checkCustomTypeApiId(customType.id);
-  await changesPage.checkCustomTypeStatus(customType.id, "New");
+  await changesPage.checkCustomTypeApiId(reusablePageType.id);
+  await changesPage.checkCustomTypeStatus(reusablePageType.id, "New");
+
+  // Slice
+  await changesPage.checkSliceName(slice.name);
+  await changesPage.checkSliceStatus(slice.name, "New");
 });
 
 test("I can update screenshots", async ({ changesPage, procedures, slice }) => {
@@ -116,22 +103,19 @@ test("I can update screenshots", async ({ changesPage, procedures, slice }) => {
   ).not.toBeVisible();
 });
 
-test("I can push the changes I have", async ({ changesPage, procedures }) => {
-  procedures.mock("getState", ({ data }) => ({
-    ...(data as Record<string, unknown>),
-    libraries: generateLibraries({ slicesCount: 0 }),
-    customTypes: generateTypes({ typesCount: 1 }),
-    remoteCustomTypes: [],
-    remoteSlices: [],
-    clientError: undefined,
-  }));
-  procedures.mock("prismicRepository.pushChanges", () => undefined, {
-    execute: false,
-  });
-
+test("I can push the changes I have", async ({
+  changesPage,
+  reusablePageType,
+  slice,
+}) => {
   await changesPage.goto();
   await expect(changesPage.loginButton).not.toBeVisible();
   await changesPage.pushChanges();
+
+  await expect(
+    changesPage.getCustomType(reusablePageType.id),
+  ).not.toBeVisible();
+  await expect(changesPage.getSliceCard(slice.name)).not.toBeVisible();
 });
 
 test("I can see an error when the push failed", async ({

playwright/tests/common/environment.spec.ts

@@ -3,13 +3,39 @@ import { expect } from "@playwright/test";
 import { test } from "../../fixtures";
 import { environments } from "../../mocks";
 
-test("I can click on the text to log in", async ({ sliceMachinePage }) => {
+test("I can click on the text to log in", async ({
+  sliceMachinePage,
+  procedures,
+}) => {
+  procedures.mock(
+    "prismicRepository.fetchEnvironments",
+    () => {
+      const error = new Error();
+      error.name = "SMUnauthenticatedError";
+      throw error;
+    },
+    { execute: false },
+  );
+
   await sliceMachinePage.gotoDefaultPage();
   await sliceMachinePage.menu.environmentSelector.loginTextButton.click();
   await expect(sliceMachinePage.loginDialog.submitButton).toBeVisible();
 });
 
-test("I can click on the icon to log in", async ({ sliceMachinePage }) => {
+test("I can click on the icon to log in", async ({
+  sliceMachinePage,
+  procedures,
+}) => {
+  procedures.mock(
+    "prismicRepository.fetchEnvironments",
+    () => {
+      const error = new Error();
+      error.name = "SMUnauthenticatedError";
+      throw error;
+    },
+    { execute: false },
+  );
+
   await sliceMachinePage.gotoDefaultPage();
   await sliceMachinePage.menu.environmentSelector.loginIconButton.click();
   await expect(sliceMachinePage.loginDialog.submitButton).toBeVisible();

playwright/tests/common/navigation.spec.ts

@@ -56,7 +56,7 @@ test("I can navigate through all menu entries", async ({
   );
 });
 
-test("I can access the repository using the open icon", async ({
+test.skip("I can access the repository using the open icon", async ({
   sliceMachinePage,
   procedures,
 }) => {

scripts/play.ts

@@ -142,6 +142,7 @@ Arguments:
 
   let [playgroundName] = args._;
   const didProvidePlaygroundName = Boolean(playgroundName);
+  let usedExistingPlayground = false;
 
   if (!playgroundName) {
     if (args.new) {
@@ -151,11 +152,12 @@ Arguments:
         PLAYGROUNDS_ROOT,
         { dirOnly: true, exclude: [".yarn", "node_modules"] },
       );
+      usedExistingPlayground = Boolean(mostRecentPlaygroundName);
       playgroundName = mostRecentPlaygroundName ?? createRandomName();
     }
   }
 
-  if (!playgroundName.startsWith(args.prefix)) {
+  if (!usedExistingPlayground && !playgroundName.startsWith(args.prefix)) {
     playgroundName = `${args.prefix}${playgroundName}`;
   }