umb: Bugfix in UMBBitString sign extensions.

davexparker · davexparker · commit 1e8821086390 · 2026-03-25T17:12:16.000Z
diff --git a/prism/src/io/github/pmctools/umbj/UMBBitString.java b/prism/src/io/github/pmctools/umbj/UMBBitString.java
@@ -202,8 +202,8 @@ public long getLong(int offset, int n) throws UMBException
 			value = (value << 1) | ((bytes[i >> 3] & (1L << (i & 7))) != 0 ? 1 : 0);
 		}
 		// Sign extend if necessary
-		if ((value & (1 << (n - 1))) != 0) {
-			value -= (1 << n);
+		if (n < 64 && (value & (1L << (n - 1))) != 0) {
+			value -= (1L << n);
 		}
 		return value;
 	}

Original file line number	Diff line number	Diff line change
`@@ -202,8 +202,8 @@ public long getLong(int offset, int n) throws UMBException`
`202`	`202`	`value = (value << 1) \| ((bytes[i >> 3] & (1L << (i & 7))) != 0 ? 1 : 0);`
`203`	`203`	`}`
`204`	`204`	`// Sign extend if necessary`
`205`		`- if ((value & (1 << (n - 1))) != 0) {`
`206`		`- value -= (1 << n);`
	`205`	`+ if (n < 64 && (value & (1L << (n - 1))) != 0) {`
	`206`	`+ value -= (1L << n);`
`207`	`207`	`}`
`208`	`208`	`return value;`
`209`	`209`	`}`