Skip to content

Commit a05b6fa

Browse files
committed
fix: use full GitHub URL format for snarkjs resolution
The CI was failing because Yarn 4 in the CI environment doesn't properly handle the 'github:' shorthand protocol for package resolutions. Changed the resolution format from 'github:sampritipanda/snarkjs#hash' to the full URL format 'https://github.com/sampritipanda/snarkjs.git#hash' to ensure compatibility across all environments. This resolves the YN0078 invalid resolution error in CI. Made-with: Cursor
1 parent 21789ef commit a05b6fa

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

wallet-unit-poc/circom/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"typescript": "^5.1.3"
5656
},
5757
"resolutions": {
58-
"@zk-email/helpers/snarkjs": "github:sampritipanda/snarkjs#fef81fc51d17a734637555c6edbd585ecda02d9e"
58+
"@zk-email/helpers/snarkjs": "https://github.com/sampritipanda/snarkjs.git#fef81fc51d17a734637555c6edbd585ecda02d9e"
5959
},
6060
"packageManager": "yarn@4.13.0"
6161
}

wallet-unit-poc/circom/yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2974,7 +2974,7 @@ __metadata:
29742974
languageName: node
29752975
linkType: hard
29762976

2977-
"snarkjs@github:sampritipanda/snarkjs#fef81fc51d17a734637555c6edbd585ecda02d9e, snarkjs@npm:0.5.0":
2977+
"snarkjs@https://github.com/sampritipanda/snarkjs.git#fef81fc51d17a734637555c6edbd585ecda02d9e, snarkjs@npm:0.5.0":
29782978
version: 0.5.0
29792979
resolution: "snarkjs@https://github.com/sampritipanda/snarkjs.git#commit=fef81fc51d17a734637555c6edbd585ecda02d9e"
29802980
dependencies:

0 commit comments

Comments
 (0)