Skip to content

Commit 64d8e97

Browse files
committed
fix(yivi): switch to named imports — yivi-* packages dropped default exports
The 1.0.0 yivi packages export YiviCore, YiviWeb, and YiviClient as named exports only. The previous `import Foo from '...'` syntax resolved to module.default which is undefined, causing the runtime error "r.default is not a constructor".
1 parent 0685f04 commit 64d8e97

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

client/src/services/createIrmaSession.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import YiviCore from '@privacybydesign/yivi-core';
2+
import { YiviCore } from '@privacybydesign/yivi-core';
33
import { setupMocks, wrappedRender } from '@test/utils';
44
import { act } from 'react-dom/test-utils';
55
import createIrmaSession, { getConfig } from './createIrmaSession';

client/src/services/createIrmaSession.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import axios from 'axios';
22
import '@privacybydesign/yivi-css';
3-
import YiviCore from '@privacybydesign/yivi-core';
4-
import YiviWeb from '@privacybydesign/yivi-web';
5-
import YiviClient from '@privacybydesign/yivi-client';
3+
import { YiviCore } from '@privacybydesign/yivi-core';
4+
import { YiviWeb } from '@privacybydesign/yivi-web';
5+
import { YiviClient } from '@privacybydesign/yivi-client';
66
import userAgent from './userAgent';
77

88
// Types
@@ -99,7 +99,7 @@ const createIrmaSession = (
9999
callBackMapping?: IStateChangeCallbackMapping,
100100
alwaysShowQRCode = false,
101101
language = 'nl'
102-
): typeof YiviCore => {
102+
): InstanceType<typeof YiviCore> => {
103103
const queryString = Object.keys(query)
104104
.map((key, index) => `${index === 0 ? '?' : ''}${key}=${(query as any)[key]}`)
105105
.join('&');

client/src/services/createIrmaVoteSession.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import YiviCore from '@privacybydesign/yivi-core';
2-
import YiviWeb from '@privacybydesign/yivi-web';
3-
import YiviClient from '@privacybydesign/yivi-client';
1+
import { YiviCore } from '@privacybydesign/yivi-core';
2+
import { YiviWeb } from '@privacybydesign/yivi-web';
3+
import { YiviClient } from '@privacybydesign/yivi-client';
44
import { IrmaAbortOnCancel, isMobile, IStateChangeCallbackMapping, IStateMachine } from '@services/createIrmaSession';
55
import { HOLDER_ELEMENT_ID } from '../pages/Vote';
66

0 commit comments

Comments
 (0)